Add guard for block info loading to edit page #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
webapp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
=======================================
Coverage 71.35% 71.35%
=======================================
Files 63 63
Lines 4151 4151
=======================================
Hits 2962 2962
Misses 1189 1189 🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/block-info-loading-guard
|
| Run status |
|
| Run duration | 07m 57s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
498
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
ml-evs/block-info-loading-guard
branch
from
ffa7de6 to
f0f75e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think one of the errors I see in development a lot has just come up during #1133 -- if a block tries to access its schema when loading (to e.g., get accepted file extensions), then this can sometimes fail if the store is not ready. This PR simply adds the existing guard for whether block schemas have been loaded before loading the block list itself. At some point we should refactor the store to do a lot of this stuff automatically.