Skip to content

Refactor file list into separate components for items/overall list #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 25, 2025

Not urgent, but a bit of tidying that separates our file list components up (and slightly restyles the icon buttons).

@ml-evs ml-evs added webapp For issues/PRs pertaining to the web interface refactoring For issues/PRs that refactor existing code/features labels Apr 25, 2025
@ml-evs ml-evs force-pushed the ml-evs/refactor-filelist branch from 557c70f to e0d43df Compare April 25, 2025 12:08
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.35%. Comparing base (1419429) to head (1dbf4ad).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   71.35%   71.35%           
=======================================
  Files          63       63           
  Lines        4151     4151           
=======================================
  Hits         2962     2962           
  Misses       1189     1189           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Apr 25, 2025

datalab    Run #3198

Run Properties:  status check failed Failed #3198  •  git commit 8bbf5d87f5 ℹ️: Merge 1dbf4adc1c9420087cb55811ad6a05e3e22ec35f into e3e39b9c2b5149d41c029739fc5a...
Project datalab
Branch Review ml-evs/refactor-filelist
Run status status check failed Failed #3198
Run duration 07m 07s
Commit git commit 8bbf5d87f5 ℹ️: Merge 1dbf4adc1c9420087cb55811ad6a05e3e22ec35f into e3e39b9c2b5149d41c029739fc5a...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 144
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/editPage.cy.js • 1 failed test • End-to-end tests (electron)

View Output

Test Artifacts
Edit Page > Clicks the upload buttons and checks that the modals are shown Test Replay Screenshots
Failed  cypress/e2e/editPage.cy.js • 1 failed test • End-to-end tests (firefox)

View Output

Test Artifacts
Edit Page > Clicks the upload buttons and checks that the modals are shown Screenshots
Failed  cypress/e2e/editPage.cy.js • 1 failed test • End-to-end tests (chrome)

View Output

Test Artifacts
Edit Page > Clicks the upload buttons and checks that the modals are shown Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low refactoring For issues/PRs that refactor existing code/features webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant