Skip to content

Bes/uv vis extra #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bes/uv vis extra #1160

wants to merge 2 commits into from

Conversation

be-smith
Copy link
Contributor

Added watchers to fileselectdropdown and filemultiselect to check if the available files change - and if the file(s) selected are removed it removes them from the modelvalue - and therefore the block

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.22%. Comparing base (1f993b5) to head (959b92a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1160   +/-   ##
=======================================
  Coverage   71.22%   71.22%           
=======================================
  Files          64       64           
  Lines        4240     4240           
=======================================
  Hits         3020     3020           
  Misses       1220     1220           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Apr 30, 2025

datalab    Run #3273

Run Properties:  status check passed Passed #3273  •  git commit 45d512c65b ℹ️: Merge 959b92ac42b7ab5beb18ccd9ad7666a77f3dac2a into 1f993b5842c539ec1382b98497e6...
Project datalab
Branch Review bes/uv-vis-extra
Run status status check passed Passed #3273
Run duration 08m 23s
Commit git commit 45d512c65b ℹ️: Merge 959b92ac42b7ab5beb18ccd9ad7666a77f3dac2a into 1f993b5842c539ec1382b98497e6...
Committer Ben Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

@ml-evs ml-evs marked this pull request as ready for review May 9, 2025 14:56
be-smith added 2 commits May 9, 2025 15:57
… the available files - if so changes model value back to null
… available files and it's in the file select it will update to not include the files and reorder the list
@ml-evs ml-evs force-pushed the bes/uv-vis-extra branch from e1a42cf to 959b92a Compare May 9, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant