Skip to content

Add spectrum selection controls to NMR insitu datablock #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented May 30, 2025

Dependencies:

Features:

  • Added user controls to select which NMR experiments to process and visualize:
    • Start/end experiment range selection
    • Step parameter for sampling
    • Input validation for parameter combinations

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.73%. Comparing base (57652b8) to head (3f9b2fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1222   +/-   ##
=======================================
  Coverage   71.73%   71.73%           
=======================================
  Files          66       66           
  Lines        4479     4479           
=======================================
  Hits         3213     3213           
  Misses       1266     1266           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented May 30, 2025

datalab    Run #3410

Run Properties:  status check passed Passed #3410  •  git commit d66c86bb01 ℹ️: Merge 3f9b2fbcf6b89c7bfc5b97a126492e27f1e3d4b7 into 57652b86cafd4fadf350817d2241...
Project datalab
Branch Review bc/insitu-ui
Run status status check passed Passed #3410
Run duration 07m 57s
Commit git commit d66c86bb01 ℹ️: Merge 3f9b2fbcf6b89c7bfc5b97a126492e27f1e3d4b7 into 57652b86cafd4fadf350817d2241...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant