Update the collection page table with the latest dynamic data table options #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
+ Coverage 71.75% 74.36% +2.61%
==========================================
Files 66 66
Lines 4485 4502 +17
==========================================
+ Hits 3218 3348 +130
+ Misses 1267 1154 -113
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/update-collection-table
|
| Run status |
|
| Run duration | 09m 16s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Thanks @BenjaminCharmes, apologies for the delay... I'd left this as a pending review comment.
ml-evs
force-pushed
the
bc/update-collection-table
branch
2 times, most recently
from
3f3eb71 to
7d14903
Compare
ml-evs
force-pushed
the
bc/update-collection-table
branch
from
7d14903 to
6efe2fe
Compare
ml-evs
reviewed
Jun 21, 2025
There was a problem hiding this comment.
UI seems to work nicely, thanks @BenjaminCharmes! Just a couple of comments about the API endpoint and tests (and whether we should switch everything over to refcodes, hopefully not too annoying)
Co-authored-by: Matthew Evans <[email protected]>
Co-authored-by: Matthew Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1192