Skip to content

Replace crypto-browserify with simple js-md5 #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Replace crypto-browserify with simple js-md5 #1251

merged 1 commit into from
Jun 25, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jun 24, 2025

Attempting to close #1250

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.28%. Comparing base (c516234) to head (2a0825f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1251   +/-   ##
=======================================
  Coverage   74.28%   74.28%           
=======================================
  Files          66       66           
  Lines        4487     4487           
=======================================
  Hits         3333     3333           
  Misses       1154     1154
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Jun 24, 2025 •
edited
Loading

datalab    Run #3519

Run Properties:  status check passed Passed #3519  •  git commit 438efe41cf ℹ️: Merge 2a0825f36bc86ac8c852448d5bc3095168147611 into c51623496dfb3e4766384289dfc2...
Project datalab
Branch Review ml-evs/md5
Run status status check passed Passed #3519
Run duration 08m 37s
Commit git commit 438efe41cf ℹ️: Merge 2a0825f36bc86ac8c852448d5bc3095168147611 into c51623496dfb3e4766384289dfc2...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

@ml-evs ml-evs added webapp For issues/PRs pertaining to the web interface javascript Pull requests that update Javascript code dependencies Pull requests that update a dependency file labels Jun 24, 2025
@ml-evs ml-evs marked this pull request as ready for review June 24, 2025 22:08
BenjaminCharmes
BenjaminCharmes approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works perfectly locally for me 👍

@ml-evs ml-evs merged commit 0f3331a into main Jun 25, 2025
18 of 26 checks passed
@ml-evs ml-evs deleted the ml-evs/md5 branch June 25, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminCharmes BenjaminCharmes BenjaminCharmes approved these changes

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code webapp For issues/PRs pertaining to the web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try to remove crypto-browserify dep
2 participants
@ml-evs @BenjaminCharmes