Skip to content

Conversation

BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Oct 2, 2025

Closes #1355

Test from #1360 work with this fix (local at least)

Copy link

cypress bot commented Oct 2, 2025

datalab    Run #3950

Run Properties:  status check failed Failed #3950  •  git commit 7b02414716 ℹ️: Merge d5d228ba17e0661068d58219563032e5f0711d0a into 63105fc801e1912dd4ef917173c4...
Project datalab
Branch Review bc/slow-itemgraph
Run status status check failed Failed #3950
Run duration 07m 23s
Commit git commit 7b02414716 ℹ️: Merge d5d228ba17e0661068d58219563032e5f0711d0a into 63105fc801e1912dd4ef917173c4...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 40
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 60
View all changes introduced in this branch ↗︎

Tests for review

Failed  batchSampleFeature.cy.js • 7 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Batch sample creation > modifies some data in the first sample Test Replay Screenshots
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots
Batch cell creation > creates a batch of cells using the template id, name, date, copyFrom, and components Test Replay Screenshots
Failed  editPage.cy.js • 10 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Edit Page > Checks editing the sample edit page Test Replay Screenshots
Edit Page > adds a chemical formula to component1 Test Replay Screenshots
Edit Page > adds some synthesis information Test Replay Screenshots
Edit Page > deletes synthesis components and re-adds them Test Replay Screenshots
Edit Page > tries to add a non-numeric value into quantity Test Replay Screenshots
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Edit Page > Clicks the upload buttons and checks that the modals are shown Test Replay Screenshots
Edit Page > Uploads an XRD file, makes an XRD block and checks that the plot works Test Replay Screenshots
Edit Page > Uploads a fake PNG image, make a Media block and checks that the image is shown Test Replay Screenshots
Edit Page > Uploads an Raman data file, makes a Raman block and checks that the plot is shown Test Replay Screenshots
Failed  sampleTablePage.cy.js • 3 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Advanced sample creation features > modifies some data in the second sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample Test Replay Screenshots
Advanced sample creation features > checks the edit page of the copied sample with components Test Replay Screenshots
Failed  batchSampleFeature.cy.js • 7 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Batch sample creation > modifies some data in the first sample Test Replay Screenshots
Batch sample creation > modifies some data in the second sample Test Replay Screenshots
Batch sample creation > checks the copied samples Test Replay Screenshots
Batch sample creation > checks the created samples Test Replay Screenshots
Batch sample creation > uses the template id, name, date, copyFrom, and components Test Replay Screenshots
Batch sample creation > plays with the number of rows Test Replay Screenshots
Batch cell creation > creates a batch of cells using the template id, name, date, copyFrom, and components Test Replay Screenshots
Failed  editPage.cy.js • 10 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Edit Page > Checks editing the sample edit page Test Replay Screenshots
Edit Page > adds a chemical formula to component1 Test Replay Screenshots
Edit Page > adds some synthesis information Test Replay Screenshots
Edit Page > deletes synthesis components and re-adds them Test Replay Screenshots
Edit Page > tries to add a non-numeric value into quantity Test Replay Screenshots
Edit Page > Add some blocks to the sample and checks unsaved warning behavior Test Replay Screenshots
Edit Page > Clicks the upload buttons and checks that the modals are shown Test Replay Screenshots
Edit Page > Uploads an XRD file, makes an XRD block and checks that the plot works Test Replay Screenshots
Edit Page > Uploads a fake PNG image, make a Media block and checks that the image is shown Test Replay Screenshots
Edit Page > Uploads an Raman data file, makes a Raman block and checks that the plot is shown Test Replay Screenshots

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.38%. Comparing base (63105fc) to head (cd78230).

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/routes/v0_1/graphs.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
+ Coverage   80.10%   80.38%   +0.28%     
==========================================
  Files          70       70              
  Lines        4759     4771      +12     
==========================================
+ Hits         3812     3835      +23     
+ Misses        947      936      -11     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/graphs.py 94.80% <95.00%> (+17.88%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review October 2, 2025 12:55
@ml-evs ml-evs force-pushed the bc/slow-itemgraph branch from 8957193 to cd78230 Compare October 17, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Item graph can slow down edit page significantly

2 participants