Skip to content

Conversation

@BenjaminCharmes
Copy link
Contributor

@BenjaminCharmes BenjaminCharmes commented Oct 2, 2025

Closes #1355

Test from #1360 work with this fix (local at least)

@cypress
Copy link

cypress bot commented Oct 2, 2025

datalab    Run #3977

Run Properties:  status check passed Passed #3977  •  git commit 49defa2825 ℹ️: Merge 811cf06be84681feec29face6ce88a58901baa0c into 1a6d5e960c415f6c5e222fd99267...
Project datalab
Branch Review bc/slow-itemgraph
Run status status check passed Passed #3977
Run duration 06m 58s
Commit git commit 49defa2825 ℹ️: Merge 811cf06be84681feec29face6ce88a58901baa0c into 1a6d5e960c415f6c5e222fd99267...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 336
View all changes introduced in this branch ↗︎

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.40%. Comparing base (63105fc) to head (811cf06).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pydatalab/src/pydatalab/routes/v0_1/graphs.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
+ Coverage   80.10%   80.40%   +0.30%     
==========================================
  Files          70       70              
  Lines        4759     4771      +12     
==========================================
+ Hits         3812     3836      +24     
+ Misses        947      935      -12     
Files with missing lines Coverage Δ
pydatalab/src/pydatalab/routes/v0_1/graphs.py 96.10% <95.00%> (+19.18%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BenjaminCharmes BenjaminCharmes marked this pull request as ready for review October 2, 2025 12:55
@ml-evs ml-evs force-pushed the bc/slow-itemgraph branch from 8957193 to cd78230 Compare October 17, 2025 12:18
Re-add old comments

Re-add old comments

Fix test_graph.py with right numbers of nodes and edges for each test (for items and collections)

Add test for item graph difference between admins and users (#1360)

Re-add get_graph_cy_format modification

Fix pytest

Re-add user_only=False

Re-add user_only=False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Item graph can slow down edit page significantly

1 participant