Add ELN collection export #1371
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt export as ELN
BenjaminCharmes
force-pushed
the
bc/export-ELN
branch
from
1913b23 to
bc808fe
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
- Coverage 80.10% 79.98% -0.12%
==========================================
Files 70 74 +4
Lines 4755 4962 +207
==========================================
+ Hits 3809 3969 +160
- Misses 946 993 +47
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/export-ELN
|
| Run status |
|
| Run duration | 07m 39s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
336
|
| View all changes introduced in this branch ↗︎ | |
BenjaminCharmes
force-pushed
the
bc/export-ELN
branch
4 times, most recently
from
3030f86 to
f83c6df
Compare
Use APScheduler Use APScheduler Use APScheduler Use APScheduler Use APScheduler Use APScheduler
BenjaminCharmes
force-pushed
the
bc/export-ELN
branch
from
748ed5c to
c85a1bf
Compare
ml-evs
reviewed
Oct 17, 2025
There was a problem hiding this comment.
This looks fantastic, thanks @BenjaminCharmes!
Just writing a couple of points here that we can discuss:
- configuring amount of resources APScheduler is allowed to use
- using pydantic models rather than direct database queries to create items etc.
- a few bits of permissions we need to be careful with
Comment on lines
+72
to
+80
| collection_exists = flask_mongo.db.collections.find_one({"collection_id": collection_id}) | ||
| if not collection_exists: | ||
| return jsonify({"status": "error", "message": "Collection not found"}), 404 | ||
|
|
||
| collection_with_perms = flask_mongo.db.collections.find_one( | ||
| {"collection_id": collection_id, **get_default_permissions(user_only=True)} | ||
| ) | ||
| if not collection_with_perms: | ||
| return jsonify({"status": "error", "message": "Access denied"}), 403 |
There was a problem hiding this comment.
Suggested change
| collection_exists = flask_mongo.db.collections.find_one({"collection_id": collection_id}) | |
| if not collection_exists: | |
| return jsonify({"status": "error", "message": "Collection not found"}), 404 | |
| collection_with_perms = flask_mongo.db.collections.find_one( | |
| {"collection_id": collection_id, **get_default_permissions(user_only=True)} | |
| ) | |
| if not collection_with_perms: | |
| return jsonify({"status": "error", "message": "Access denied"}), 403 | |
| collection_with_perms = flask_mongo.db.collections.find_one( | |
| {"collection_id": collection_id, **get_default_permissions(user_only=True)} | |
| ) | |
| if not collection_with_perms: | |
| return jsonify({"status": "error", "message": "Collection not found"}), 404 |
Better not to leak IDs that exist but the user does not have permission for, so just treat missing ID as 404
There was a problem hiding this comment.
Can probably also set user_only=False
ml-evs
reviewed
Oct 17, 2025
| source_path = Path(file_data["location"]) | ||
| if source_path.exists(): | ||
| dest_file = item_folder / file_data["name"] | ||
| shutil.copy2(source_path, dest_file) |
There was a problem hiding this comment.
Somehow the actual raw data files are not making it into the .eln file when I try to export them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1332 & #1046
Implements a new API endpoint and background process to export full collections as .eln files