[RAPTOR-14353] Gavrenkov/poc drum watchdog v2

[s-gavrenkov]

This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.

Results:

Summary

Rationale

[semgrep-code-datarobot]

Semgrep identified an issue in your code:
Found 'subprocess' function 'run' with 'shell=True'. This is dangerous because this call will spawn the command using a shell process. Doing so propagates current shell settings and variables, which makes it much easier for a malicious actor to execute commands. Use 'shell=False' instead.

To resolve this comment:

✨ Commit Assistant fix suggestion

Suggested change

	subprocess.run(f"kill {pid}", shell=True)
	subprocess.run(f"kill {pid}", shell=False)

View step-by-step instructions

1. Change the subprocess.run(f"kill {pid}", shell=True) call to avoid using the shell.
2. Update the line to pass the command and arguments as a list, like this: subprocess.run(["kill", str(pid)]).
   This prevents shell injection vulnerabilities and makes the command execution safer, especially when working with dynamic input.

💬 Ignore this finding

Reply with Semgrep commands to ignore this finding.

• /fp <comment> for false positive
• /ar <comment> for acceptable risk
• /other <comment> for all other reasons

Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by subprocess-shell-true.

_{You can view more details about this finding in the Semgrep AppSec Platform.}