PrefetchingResultSetIterator: fix bug w/r/t intermediate zero-row pages #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zero row pages (that aren't the last) can sometimes happen, for example when using "filtering". The iterator has a logic bug which makes it throw an exception when encountering this. Fix this issue with minimal code changes and add associated unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How did the Spark Cassandra Connector Work or Not Work Before this Patch
Zero row pages (that aren't the last) can sometimes happen, for example when using "filtering".
The iterator has a logic bug which makes it throw an exception when encountering this.
Fix this issue with minimal code changes and add associated unit test.
General Design of the patch
The fix is rather simple: skip such pages in maybePrefetch (if -> while), and call maybePrefetch in constructor in the event the first page(s) being affected.
Fixes: SPARKC-717
How Has This Been Tested?
Unit test has been added to validate and check the presence of the fix.
Checklist: