Async Submit#39
Open
luccasmmg wants to merge 10 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Adds CSV sampling at resource submission time to detect any numeric field whose values exceed JavaScript MAX_SAFE_INTEGER (9,007,199,254,740,991). Affected fields are silently rounded in the browser causing wrong filter suggestions in the Data Explorer. - _sample_csv_for_precision_risk(): streams first 100 rows of uploaded CSV, checks every number/integer/float schema field for large values regardless of column name (Option B — no keyword filtering) - aircan_submit(): calls the helper synchronously before the Airflow job is queued; flashes a notice to the editor and stores precision_warning on the resource extras via the model (bypassing hooks to avoid infinite loop); clears the flag automatically on clean re-ingest - plugin.py: reverts before_resource_create approach; keeps except block clean - 16 unit tests covering helper logic, boundary values and aircan_submit integration Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR essentially moves the logic for the
datapusher_submitaction into a CKAN Job