Repository navigation
Add domain schema: instruments, tiles, epochs, and mosaics - #28
Merged
Merged
Conversation
Replaces the Stage 0 placeholder schema with the real astronomical domain model needed for tile-based mosaicing, and fixes a Docker dev-environment gap (migrations/ baked into images, not bind-mounted) discovered while verifying it end-to-end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alembic checkstays clean with no autogenerate exclusions needed.migrations/was baked into images at build time (not bind-mounted likesrc/), so a newly-added migration was invisible inside a running container without a full rebuild. Added a dev-only bind mount onapiand removed the now-unusedmigrations//alembic.inicopy from the worker image (it never runs alembic).postgres:16service, since the new migration requires the extension.assessPromptnow applies fully-deterministic fixes directly (with confirmation) instead of always routing them through Gemini; added standing Q3C-indexing and MOC-placement conventions to the Gemini coworking protocol for future domain-model docs.CLI Verification
All steps completed prior to PR creation via
genTests.feature/domain-modelsdocker compose build worker_light worker_heavy(Dockerfile changed);apirecreated for the new bind mountdocker compose up -d api worker_light worker_heavydocker compose exec api alembic upgrade head(confirmed at0007/head)docker compose exec api uv run pytest --cov=src --cov-fail-under=90 -q— 126 passed, 1 skipped (pre-existing host-only test module, expected inside a container), 98.86% coveragedocs/diagrams/infrastructure_topology.md— N/A, no infrastructure topology changeApplication QA
All steps completed and verified prior to PR creation via
genTests.reset-dbexercised the full migration chain (0001→0007) and reference-data seeding —instruments/bandsheld exactly the expected NIRCam/MIRI/F150W/F277W rows, confirmed in DBeaverpg_extension/pg_indexesshowedq3cinstalled and bothix_tile_q3c/ix_level2_image_q3cpresent, confirmed in DBeaverInstrumentinsert via DBeaver was rejected with a unique-violation error🤖 Generated with Claude Code