Skip to content

Remove incorrect defers that would free internal vips pointers #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidbyttow merged 4 commits into from
Mar 6, 2026
Merged

Remove incorrect defers that would free internal vips pointers #511

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
997eee5
Remove incorrect defer in vipsImageGetMetaLoader
davidbyttow Mar 5, 2026
44bac69
Remove incorrect defer in vipsImageGetDelay
davidbyttow Mar 5, 2026
7c4fa11
Remove incorrect defer in vipsImageGetBackground
davidbyttow Mar 5, 2026
f69fa90
Remove incorrect defer in vipsImageGetString
davidbyttow Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions vips/operations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,15 +691,13 @@ func vipsSetPageHeight(in *C.VipsImage, height int) {

func vipsImageGetMetaLoader(in *C.VipsImage) (string, bool) {
var out *C.char
defer freeCString(out)
code := int(C.get_meta_loader(in, &out))
return C.GoString(out), code == 0
}

func vipsImageGetDelay(in *C.VipsImage, n int) ([]int, error) {
incOpCounter("imageGetDelay")
var out *C.int
defer gFreePointer(unsafe.Pointer(out))

if err := C.get_image_delay(in, &out); err != 0 {
return nil, handleVipsError()
Expand Down Expand Up @@ -727,7 +725,6 @@ func vipsImageGetBackground(in *C.VipsImage) ([]float64, error) {
incOpCounter("imageGetBackground")
var out *C.double
var n C.int
defer gFreePointer(unsafe.Pointer(out))

if err := C.get_background(in, &out, &n); err != 0 {
return nil, handleVipsError()
Expand Down Expand Up @@ -854,7 +851,6 @@ func vipsImageGetString(in *C.VipsImage, name string) string {
cField := C.CString(name)
defer freeCString(cField)
var cFieldValue *C.char
defer freeCString(cFieldValue)
if int(C.image_get_string(in, cField, &cFieldValue)) == 0 {
return C.GoString(cFieldValue)
}
Expand Down