Skip to content

Fix C code bugs in set_image_delay and label #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidbyttow merged 2 commits into from
Mar 6, 2026
Merged

Fix C code bugs in set_image_delay and label #512

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a9ff8d
Fix void function returning a value in set_image_delay
davidbyttow Mar 5, 2026
6e4e184
Fix label() error return values: use -1 instead of 1
davidbyttow Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vips/operations.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ int get_image_delay(VipsImage *in, int **out) {
}

void set_image_delay(VipsImage *in, const int *array, int n) {
return vips_image_set_array_int(in, "delay", array, n);
vips_image_set_array_int(in, "delay", array, n);
}

int get_image_loop(VipsImage *in) {
Expand Down Expand Up @@ -445,7 +445,7 @@ int label(VipsImage *in, VipsImage **out, LabelOptions *o) {
vips_embed(t[2], &t[3], o->OffsetX, o->OffsetY, t[2]->Xsize + o->OffsetX,
t[2]->Ysize + o->OffsetY, NULL)) {
g_object_unref(base);
return 1;
return -1;
}
if (vips_black(&t[4], 1, 1, NULL) ||
vips_linear(t[4], &t[5], ones, o->Color, 3, NULL) ||
Expand All @@ -454,11 +454,11 @@ int label(VipsImage *in, VipsImage **out, LabelOptions *o) {
vips_embed(t[7], &t[8], 0, 0, in->Xsize, in->Ysize, "extend",
VIPS_EXTEND_COPY, NULL)) {
g_object_unref(base);
return 1;
return -1;
}
if (vips_ifthenelse(t[3], t[8], in, out, "blend", TRUE, NULL)) {
g_object_unref(base);
return 1;
return -1;
}
g_object_unref(base);
return 0;
Expand Down
Loading