Minor cleanup: fix typo and remove stale TODO#514
Merged
davidbyttow merged 2 commits intomasterfrom Mar 6, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The field is part of the public API so it stays, but the TODO has been open since the field was added and is unlikely to be implemented. Remove the misleading comment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scalar.IsZerodoc commentPngExportParams.Profile(field kept for API compatibility)Skipped removing
ImageFields()wrapper since it's part of the public API.Test plan
go build ./vips/🤖 Generated with Claude Code
Note
Fix comment typo in
vips.Scalar.IsZeroand remove stale TODO fromvips.PngExportParams.Profileto perform minor cleanupCorrect a comment typo in vips/math.go and remove an inline TODO from
vips.PngExportParams.Profilein vips/image.go.📍Where to Start
Start with the comment changes in vips/math.go, then review the
vips.PngExportParamsstruct in vips/image.go.Macroscope summarized cf3f52e.