Add WebP shrink-on-load support via scale parameter#516
Open
JakeChampion wants to merge 1 commit intodavidbyttow:masterfrom
Open
Add WebP shrink-on-load support via scale parameter#516JakeChampion wants to merge 1 commit intodavidbyttow:masterfrom
JakeChampion wants to merge 1 commit intodavidbyttow:masterfrom
Conversation
Expose the libvips webpload "scale" parameter as `WebpScaleFactor` on `ImportParams`, allowing callers to downscale WebP images during decode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the libvips webpload "scale" parameter as
WebpScaleFactoronImportParams, allowing callers to downscale WebP images during decodeNote
Add WebP shrink-on-load via
ImportParams.WebpScaleFactorand passLoadParams.webpScaleto the WebP loaderscaleoptionIntroduce a WebP scale-in parameter, thread it through
createImportParamstoLoadParams.webpScale, set it inset_webpload_options, and add tests for dimension changes and option string output.📍Where to Start
Start with
set_webpload_optionsin foreign.c, then reviewcreateImportParamsin foreign.go and theImportParamsadditions in image.go.Macroscope summarized dd8f50b.