refactor!(macro) use outer macro pattern for modules #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenira
force-pushed
the
feat/outer-macro
branch
3 times, most recently
from
07552af to
aabda88
Compare
Xenira
force-pushed
the
feat/outer-macro
branch
from
aabda88 to
440661b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP for switching to the outer macro pattern.
TODO:
Discussion and information in #335.
In its current state this will be a major BC, but improve DX a lot.
BREAKING CHANGE: Starting with this modules will need to be declared differently. See for more information