Repository navigation
Example SD files by URL, a stale solver window fix, PCM5102A ad - #395
Merged
Merged
Conversation
…e bytes A gallery example can pre-load a board's built-in microSD (board.sdFiles). Inline base64 is fine for a text file, but a music player's MP3s would ride in the main bundle every visitor downloads. An entry may now name a `url` (same origin, e.g. /examples-media/...): loadExample fetches it before the canvas changes and stores the bytes on the board exactly like an inline file or an SD Card panel upload. A file that cannot be fetched is left off the card and logged, so one missing asset costs that file, not the example.
"Circuit solver problem: no such vector undefined" on Run, intermittently, on a circuit with SPI-driven pads. closeWindow() closes the pad timeline's window and queues its publish on the solver chain; when a rebuild was already queued there, the publish ran after it, and the window's levels, indexed by the OLD deck's pads, were paired with the NEW deck's sources. The new deck had one pad more, so ngspice got `alter V_<board>_D10 dc undefined`. The publish now runs only while its timeline is still the current one. The rebuild already published the state the pads hold, and edges recorded during it went onto the new timeline, so a stale window has nothing left to say. Regression test reproduces the race with a fake solver (fails before: one alter with an undefined level).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small changes behind the XIAO Pod example (MP3 player on XIAO ESP32S3 Sense + Round Display + PCM5102A I2S DAC) on velxio.dev:
Tests: full vitest suite green in both shards (5369 + 6041).