Skip to content

Conversation

@panchal
Copy link

@panchal panchal commented Oct 1, 2019

This PR,

  • Brings Hilbert Packing support on top Bulk Load.
  • Allows user choice between STR and Hilbert packing techniques.

Ref: http://www.cs.cmu.edu/~christos/PUBLICATIONS.OLDER/cikm93.pdf

This was done back in 2017, but never got chance to propose here. Addresses #74.
Hope this fits the vision, let me know. Thanks.

Deven Panchal added 2 commits September 30, 2019 21:09
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@569cf17). Click here to learn what that means.
The diff coverage is 82.22%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #98   +/-   ##
=========================================
  Coverage          ?   80.92%           
  Complexity        ?      804           
=========================================
  Files             ?       73           
  Lines             ?     2144           
  Branches          ?      290           
=========================================
  Hits              ?     1735           
  Misses            ?      321           
  Partials          ?       88
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/github/davidmoten/rtree/PackAlgo.java 100% <100%> (ø) 1 <1> (?)
...c/main/java/com/github/davidmoten/rtree/RTree.java 94.95% <80.95%> (ø) 65 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 569cf17...9d18cac. Read the comment docs.

@davidmoten
Copy link
Owner

Apologies, this slipped my attention! Would you still like me to review?

@panchal
Copy link
Author

panchal commented May 16, 2020

Hello David, Yes. I would greatly appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants