Skip to content

feat: improve private repo access handling in web/sandbox flow #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmdavis419 wants to merge 1 commit into
base: codex/pr-h-instance-error-quality
Choose a base branch
from
Open

feat: improve private repo access handling in web/sandbox flow #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions apps/web/src/convex/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,38 @@ const throwResourceError = (error: WebError): never => {
throw error;
};

const hasCloudGitToken = () => Boolean(process.env.BTCA_GIT_TOKEN?.trim());

const isGitHubUrl = (url: string) => {
const parsed = Result.try(() => new URL(url)).match({
ok: (value) => value,
err: () => null
});
return parsed?.hostname.toLowerCase() === 'github.com';
};

const preflightResourceUrlAccess = async (
url: string
): Promise<{ ok: true } | { ok: false; error: string }> => {
if (hasCloudGitToken()) return { ok: true };
if (!isGitHubUrl(url)) return { ok: true };

const result = await Result.tryPromise(() =>
fetch(url, { method: 'HEAD', redirect: 'manual' as RequestRedirect })
);
if (Result.isError(result)) return { ok: true };

if (result.value.status === 401 || result.value.status === 403 || result.value.status === 404) {
return {
ok: false,
error:
'Repository appears private or inaccessible from cloud mode. Configure BTCA_GIT_TOKEN for private repository access, or use local CLI mode.'
};
}

return { ok: true };
};

// Resource validators
const globalResourceValidator = v.object({
name: v.string(),
Expand Down Expand Up @@ -305,6 +337,11 @@ export const addCustomResource = mutation({
throwResourceError(nameResult.error);
}

const preflight = await preflightResourceUrlAccess(args.url);
if (!preflight.ok) {
throwResourceError(new WebValidationError({ message: preflight.error, field: 'url' }));
}

const resourceId = await ctx.db.insert('userResources', {
instanceId: instance._id,
projectId: args.projectId,
Expand Down