Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adapt changes out of release 3.0.0 by DB UI core #2710

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+25,466 −27,352
Open

refactor: adapt changes out of release 3.0.0 by DB UI core #2710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e4aaff
refactor: updated DB UI Core version
mfranzke Aug 6, 2024
5005fec
refactor: adapted the HTML changes out of DB UI Core
mfranzke Aug 6, 2024
cab0794
fix(chip): remove aria-hidden to expose label in a11y tree (#2659)
jonaskuske Aug 6, 2024
fe51496
refactor: updated snapshots
mfranzke Aug 6, 2024
f1b5b98
Merge branch 'main' into 2709-refactor-adapt-changes-out-of-release-3…
mfranzke Aug 8, 2024
bc477ff
chore: update snapshots
nmerget Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified e2e/cypress/snapshots/base/db-brand.cy.js/db-brand.png
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clickable sitename doesn't look correct.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-breadcrumb.cy.js/db-breadcrumb.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-button.cy.js/db-button.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-dropdown.cy.js/db-dropdown.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-header.cy.js/db-header.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-input.cy.js/db-input.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-language-switcher.cy.js/db-language-switcher.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-mainnavigation.cy.js/db-mainnavigation.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-metanavigation.cy.js/db-metanavigation.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-overflow-menu.cy.js/db-overflow-menu.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-progress.cy.js/db-progress.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-select.cy.js/db-select.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-tab-bar.cy.js/db-tab-bar.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-table.cy.js/db-table.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified e2e/cypress/snapshots/base/db-textarea.cy.js/db-textarea.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
52,770 changes: 25,444 additions & 27,326 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions packages/db-ui-elements-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@
},
"devDependencies": {
"@angular-devkit/build-angular": "17.3.8",
"@angular/animations": "^17.3.11",
"@angular/animations": "^17.3.12",
"@angular/cli": "17.3.8",
"@angular/common": "^17.3.11",
"@angular/compiler": "^17.3.11",
"@angular/compiler-cli": "17.3.11",
"@angular/core": "^17.3.11",
"@angular/forms": "^17.3.11",
"@angular/platform-browser": "^17.3.11",
"@angular/platform-browser-dynamic": "^17.3.11",
"@angular/common": "^17.3.12",
"@angular/compiler": "^17.3.12",
"@angular/compiler-cli": "17.3.12",
"@angular/core": "^17.3.12",
"@angular/forms": "^17.3.12",
"@angular/platform-browser": "^17.3.12",
"@angular/platform-browser-dynamic": "^17.3.12",
"@rollup/plugin-commonjs": "26.0.1",
"@rollup/plugin-json": "6.1.0",
"@rollup/plugin-node-resolve": "15.2.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/db-ui-elements-angular/projects/lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"name": "lib",
"version": "0.0.1",
"peerDependencies": {
"@angular/common": "^17.3.11",
"@angular/core": "^17.3.11"
"@angular/common": "^17.3.12",
"@angular/core": "^17.3.12"
},
"dependencies": {
"tslib": "^2.6.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/db-ui-elements-stencil/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"puppeteer": "^22.12.1"
},
"dependencies": {
"@db-ui/core": "^2.22.0"
"@db-ui/core": "^3.0.0"
},
"license": "Apache-2.0",
"publishConfig": {
Expand Down
8 changes: 2 additions & 6 deletions packages/db-ui-elements-stencil/src/components/db-chip/db-chip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
import { Component, Host, h, Prop } from '@stencil/core';
import { uuid } from '../../utils/utils';

Expand Down Expand Up @@ -75,12 +76,7 @@ export class DbChip {
name={this.name}
checked={this.selected}
/>
<label
htmlFor={this.input_id}
role="button"
aria-hidden="true"
data-variant={this.variant}
>
<label htmlFor={this.input_id} data-variant={this.variant}>
{this.icon ? <db-icon variant="20-outline" icon={this.icon} /> : null}
<slot />
{this.iconafter ? (
Expand Down
18 changes: 9 additions & 9 deletions showcase/angular-lts-showcase/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,22 @@
},
"private": true,
"dependencies": {
"@angular/animations": "17.3.11",
"@angular/common": "17.3.11",
"@angular/compiler": "17.3.11",
"@angular/core": "17.3.11",
"@angular/forms": "17.3.11",
"@angular/platform-browser": "17.3.11",
"@angular/platform-browser-dynamic": "17.3.11",
"@angular/router": "17.3.11",
"@angular/animations": "17.3.12",
"@angular/common": "17.3.12",
"@angular/compiler": "17.3.12",
"@angular/core": "17.3.12",
"@angular/forms": "17.3.12",
"@angular/platform-browser": "17.3.12",
"@angular/platform-browser-dynamic": "17.3.12",
"@angular/router": "17.3.12",
"rxjs": "7.8.1",
"tslib": "2.6.3",
"zone.js": "0.14.8"
},
"devDependencies": {
"@angular-devkit/build-angular": "17.3.8",
"@angular/cli": "17.3.8",
"@angular/compiler-cli": "17.3.11",
"@angular/compiler-cli": "17.3.12",
"injection-js": "2.4.0",
"rxjs": "7.8.1",
"typescript": "5.4.5"
Expand Down
Loading