Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise support, bump to 2.0.1 #40

Closed
wants to merge 2 commits into from
Closed

Conversation

Cretezy
Copy link

@Cretezy Cretezy commented Jan 27, 2018

I've also generated a yarn.lock for use with Yarn. This won't affect anything.

This does add a dependency on promise, which adds 0.9KB on the final build size (7.09 KB -> 7.18 KB).

@dchest
Copy link
Owner

dchest commented Jan 27, 2018

Thanks for PR, however this package is targeting really old browsers, and I hate including shims, especially if it requires external dependencies. Since it's simple enough to just wrap it into a promise in user code, I don't think it's necessary.

See also #28

BTW, my newer package in StableLib uses promises exclusively, so you can switch to it instead https://github.com/StableLib/stablelib/tree/master/packages/scrypt

@dchest dchest closed this Jan 27, 2018
@Cretezy
Copy link
Author

Cretezy commented Jan 27, 2018

Perfectly understandable. I'm going to maintain my own fork with a more modern toolkit (Rollup, Jest, ES6+)! Thank you for the library.

@Cretezy
Copy link
Author

Cretezy commented Jan 29, 2018

https://github.com/Cretezy/scrypt-async-modern

Basically I've updated the code to ES6 (still compiled down to ES5) ,moved to Rollup and Jest, and a few cleanups. It's the same code but modernized overall. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants