Skip to content

Using checkLength to determine max length for DA, DT, TM (Query with range matching) #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PantelisGeorgiadis
Copy link
Contributor

This PR patches the work of @mishijima on #427.

More specifically,

  • Removes the allowRangeMatching because the existence of rangeMatchingMaxLength, for a VR, gives the same information.
  • Uses the existing checkLength function for DA, TM and DT to determine a range query and return whether the length is valid or not.
  • Updates the unit tests to perform a full roundtrip between the naturalized and denaturalized worlds.
  • The build output was used with dcmjs-dimse to make sure that range queries are working as expected.

@pieper please review and if you approve and merge, please close #427 since it is redundant.

Copy link

netlify bot commented May 3, 2025

Deploy Preview for dcmjs2 ready!

Name Link
🔨 Latest commit 9f774fa
🔍 Latest deploy log https://app.netlify.com/sites/dcmjs2/deploys/681648057df7a50008162e83
😎 Deploy Preview https://deploy-preview-433--dcmjs2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pieper pieper merged commit cf933a6 into dcmjs-org:master May 6, 2025
13 of 14 checks passed
@PantelisGeorgiadis
Copy link
Contributor Author

Thank you for merging this PR @pieper! Any plans for releasing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants