Simu pa

[PAduverne]

Update on the transformation laws for photometric systems and allows injection of objects at specified location for simulations

[pep8speaks]

Hello @PAduverne! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file gmadet/phot_conversion.py:

Line 190:1: W293 blank line contains whitespace
Line 195:61: E127 continuation line over-indented for visual indent
Line 196:75: W291 trailing whitespace
Line 197:59: E127 continuation line over-indented for visual indent
Line 197:80: E501 line too long (94 > 79 characters)
Line 197:95: W291 trailing whitespace
Line 198:59: E127 continuation line over-indented for visual indent
Line 198:80: E501 line too long (94 > 79 characters)
Line 198:95: W291 trailing whitespace
Line 199:59: E127 continuation line over-indented for visual indent
Line 200:1: W293 blank line contains whitespace
Line 205:61: E127 continuation line over-indented for visual indent
Line 206:79: W291 trailing whitespace
Line 207:59: E127 continuation line over-indented for visual indent
Line 207:80: E501 line too long (94 > 79 characters)
Line 207:95: W291 trailing whitespace
Line 208:59: E127 continuation line over-indented for visual indent
Line 208:80: E501 line too long (101 > 79 characters)
Line 209:1: W293 blank line contains whitespace
Line 210:1: W293 blank line contains whitespace
Line 211:5: E303 too many blank lines (2)
Line 215:61: E127 continuation line over-indented for visual indent
Line 216:79: W291 trailing whitespace
Line 217:59: E127 continuation line over-indented for visual indent
Line 217:80: E501 line too long (94 > 79 characters)
Line 217:95: W291 trailing whitespace
Line 218:59: E127 continuation line over-indented for visual indent
Line 218:80: E501 line too long (101 > 79 characters)
Line 219:1: W293 blank line contains whitespace
Line 224:61: E127 continuation line over-indented for visual indent
Line 225:79: W291 trailing whitespace
Line 226:59: E127 continuation line over-indented for visual indent
Line 226:80: E501 line too long (105 > 79 characters)
Line 226:106: W291 trailing whitespace
Line 227:59: E127 continuation line over-indented for visual indent
Line 227:80: E501 line too long (90 > 79 characters)
Line 228:1: W293 blank line contains whitespace
Line 245:1: W293 blank line contains whitespace
Line 246:19: E261 at least two spaces before inline comment
Line 246:20: E262 inline comment should start with '# '
Line 246:48: W291 trailing whitespace
Line 247:19: E261 at least two spaces before inline comment
Line 247:20: E262 inline comment should start with '# '
Line 250:1: W293 blank line contains whitespace
Line 254:80: E501 line too long (81 > 79 characters)
Line 256:1: W293 blank line contains whitespace
Line 260:80: E501 line too long (81 > 79 characters)
Line 262:1: W293 blank line contains whitespace
Line 266:80: E501 line too long (81 > 79 characters)
Line 268:1: W293 blank line contains whitespace
Line 272:80: E501 line too long (81 > 79 characters)
Line 274:1: W293 blank line contains whitespace
Line 276:1: W293 blank line contains whitespace
Line 276:1: W391 blank line at end of file

Comment last updated at 2020-10-23 15:57:29 UTC

[codecov-io]

Codecov Report

Merging #14 into master will increase coverage by 0.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   53.79%   54.00%   +0.21%     
==========================================
  Files          33       33              
  Lines        2781     2781              
  Branches      403      403              
==========================================
+ Hits         1496     1502       +6     
+ Misses       1150     1144       -6     
  Partials      135      135              

Impacted Files	Coverage Δ
gmadet/phot_conversion.py	5.46% <0.00%> (ø)
gmadet/substraction.py	64.78% <0.00%> (+4.22%)	⬆️