Refactoring README.md

src/main/java/io/pillopl/library/catalogue/Book.java

@@ -23,7 +23,6 @@ class Book {
     }
 }
 
-
 @Value
 class Title {
 
@@ -35,7 +34,6 @@ class Title {
         }
         this.title = title.trim();
     }
-
 }
 
 @Value
@@ -49,4 +47,4 @@ class Author {
         }
         this.name = name.trim();
     }
-}
+}

src/main/java/io/pillopl/library/catalogue/BookInstance.java

@@ -20,6 +20,5 @@ class BookInstance {
 
     static BookInstance instanceOf(Book book, BookType bookType) {
         return new BookInstance(book.getBookIsbn(), new BookId(UUID.randomUUID()), bookType);
-
     }
 }

src/main/java/io/pillopl/library/catalogue/BookType.java

@@ -3,4 +3,3 @@
 public enum BookType {
     Restricted, Circulating
 }
-

src/main/java/io/pillopl/library/catalogue/Catalogue.java

@@ -37,7 +37,4 @@ private BookInstance saveAndPublishEvent(BookInstance bookInstance) {
         domainEvents.publish(new BookInstanceAddedToCatalogue(bookInstance));
         return bookInstance;
     }
-
-
 }
-

src/main/java/io/pillopl/library/catalogue/CatalogueDatabase.java

@@ -45,7 +45,6 @@ Option<Book> findBy(ISBN isbn) {
 
         }
     }
-
 }
 
 @Data

src/main/java/io/pillopl/library/catalogue/CatalogueDatabaseConfig.java

@@ -38,4 +38,4 @@ DataSource dataSource() {
                 .addScript("create_catalogue_book.sql")
                 .build();
     }
-}
+}

src/main/java/io/pillopl/library/catalogue/ISBN.java

@@ -16,6 +16,5 @@ class ISBN {
             throw new IllegalArgumentException("Wrong ISBN!");
         }
         this.isbn = isbn.trim();
-
     }
 }

src/main/java/io/pillopl/library/commons/commands/BatchResult.java

@@ -2,4 +2,4 @@
 
 public enum BatchResult {
     FullSuccess, SomeFailed
-}
+}

src/main/java/io/pillopl/library/commons/commands/Result.java

@@ -2,4 +2,4 @@
 
 public enum Result {
     Success, Rejection
-}
+}

src/main/java/io/pillopl/library/commons/events/publisher/StoreAndForwardDomainEventPublisher.java

@@ -7,7 +7,6 @@
 import org.springframework.scheduling.annotation.Scheduled;
 import org.springframework.transaction.annotation.Transactional;
 
-
 @AllArgsConstructor
 public class StoreAndForwardDomainEventPublisher implements DomainEvents {
 

src/main/resources/create_catalogue_book.sql

@@ -4,13 +4,10 @@ CREATE TABLE IF NOT EXISTS catalogue_book (
   title VARCHAR(100) NOT NULL,
   author VARCHAR(100) NOT NULL);
 
-
 CREATE TABLE IF NOT EXISTS catalogue_book_instance (
   id INTEGER IDENTITY PRIMARY KEY,
   isbn VARCHAR(100) NOT NULL,
   book_id UUID NOT NULL);
 
 CREATE SEQUENCE catalogue_book_seq;
 CREATE SEQUENCE catalogue_book_instance_seq;
-
-

src/main/resources/create_patron_db.sql

@@ -1,5 +1,17 @@
-CREATE TABLE IF NOT EXISTS patron_database_entity (id INTEGER IDENTITY PRIMARY KEY, patron_type VARCHAR(100) NOT NULL, patron_id UUID UNIQUE);
+CREATE TABLE IF NOT EXISTS patron_database_entity (
+  id INTEGER IDENTITY PRIMARY KEY,
+  patron_type VARCHAR(100) NOT NULL,
+  patron_id UUID UNIQUE);
 
-CREATE TABLE IF NOT EXISTS hold_database_entity (id INTEGER IDENTITY PRIMARY KEY, book_id UUID NOT NULL, patron_id UUID NOT NULL, library_branch_id UUID NOT NULL, patron_database_entity INTEGER NOT NULL, till TIMESTAMP NOT NULL);
+CREATE TABLE IF NOT EXISTS hold_database_entity (
+  id INTEGER IDENTITY PRIMARY KEY,
+  book_id UUID NOT NULL, patron_id UUID NOT NULL,
+  library_branch_id UUID NOT NULL,
+  patron_database_entity INTEGER NOT NULL,
+  till TIMESTAMP NOT NULL);
 
-CREATE TABLE IF NOT EXISTS overdue_checkout_database_entity (id INTEGER IDENTITY PRIMARY KEY, book_id UUID NOT NULL, patron_id UUID NOT NULL, library_branch_id UUID NOT NULL, patron_database_entity INTEGER NOT NULL);
+CREATE TABLE IF NOT EXISTS overdue_checkout_database_entity (
+  id INTEGER IDENTITY PRIMARY KEY,
+  book_id UUID NOT NULL, patron_id UUID NOT NULL,
+  library_branch_id UUID NOT NULL,
+  patron_database_entity INTEGER NOT NULL);

src/main/resources/create_sheets_db.sql

@@ -9,7 +9,6 @@ id INTEGER IDENTITY PRIMARY KEY,
   checked_out_at_branch UUID,
   checkout_till TIMESTAMP);
 
-
 CREATE TABLE IF NOT EXISTS holds_sheet (
 id INTEGER IDENTITY PRIMARY KEY,
   book_id UUID NOT NULL,
@@ -25,4 +24,3 @@ id INTEGER IDENTITY PRIMARY KEY,
 
 CREATE SEQUENCE holds_sheet_seq;
 CREATE SEQUENCE checkouts_sheet_seq;
-

src/test/groovy/io/pillopl/library/ModularArchitectureTest.java

@@ -38,6 +38,4 @@ public class ModularArchitectureTest {
                     .should()
                     .dependOnClassesThat()
                     .resideInAPackage("..lending..");
-
-
-}
+}

src/test/groovy/io/pillopl/library/catalogue/AddBookToCatalogueTest.groovy

@@ -23,7 +23,6 @@ class AddBookToCatalogueTest extends Specification {
         then:
             result.isSuccess()
             result.get() == Result.Success
-
     }
 
     def 'should add a new book instance to catalogue'() {
@@ -38,7 +37,6 @@ class AddBookToCatalogueTest extends Specification {
             result.get() == Result.Success
         and:
             1 * domainEvents.publish(_ as BookInstanceAddedToCatalogue)
-
     }
 
     def 'should reject adding a new book instance to catalogue when book isbn does not exist'() {
@@ -53,7 +51,6 @@ class AddBookToCatalogueTest extends Specification {
             result.get() == Result.Rejection
         and:
             0 * domainEvents.publish(_ as BookInstanceAddedToCatalogue)
-
     }
 
     def 'should fail when adding a book if database fails'() {
@@ -81,13 +78,11 @@ class AddBookToCatalogueTest extends Specification {
     void databaseWorks() {
         catalogueDatabase.saveNew(_ as Book) >> null
         catalogueDatabase.saveNew(_ as BookInstance) >> null
-
     }
 
     void databaseDoesNotWork() {
         catalogueDatabase.saveNew(_ as Book) >> { (new IllegalStateException()) }
         catalogueDatabase.saveNew(_ as BookInstance) >> { (new IllegalStateException()) }
-
     }
 
     void thereIsBookWith(String isbn) {

src/test/groovy/io/pillopl/library/catalogue/BookTitleAuthorISBNTest.groovy

@@ -9,7 +9,6 @@ class BookTitleAuthorISBNTest extends Specification {
             Title title = new Title("   to trim  ")
         expect:
             title.title == "to trim"
-
     }
 
     def "author should be trimmed"() {
@@ -68,5 +67,3 @@ class BookTitleAuthorISBNTest extends Specification {
             thrown(IllegalArgumentException)
     }
 }
-
-

src/test/resources/logback-test.xml

@@ -10,4 +10,4 @@
     <root level="WARN">
         <appender-ref ref="STDOUT" />
     </root>
-</configuration>
+</configuration>