Skip to content

fix: update plugin dependency checks and notifications, fixes #402 #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AkibaAT
Copy link
Collaborator

@AkibaAT AkibaAT commented Apr 28, 2025

The Problem/Issue/Bug:

How this PR Solves the Problem:

Completely reworked the dependency checks, and how they're being presented.

  • Required Plugin dependencies:
    • Remote Execution Agent (intellij.platform.ijent.impl)
    • Docker
  • Optional Plugin dependencies:
    • Terminal (plugin.name.terminal)
  • Dependencies for PHP auto-configure:
    • PHP (com.jetbrains.php)
    • PHP Docker (org.jetbrains.plugins.phpstorm-remote-interpreter)
    • PHP Remote Interpreter (org.jetbrains.plugins.phpstorm-docker)
  • Dependencies for node.js auto-configure:
    • Node.js (NodeJS)
    • Node.js Remote Interpreter (org.jetbrains.plugins.node-remote-interpreter)
  • Dependencies for database auto-configure:
    • Database Tools and SQL (com.intellij.database)

Manual Testing Instructions:

Install ddev-intellij-plugin-0.0.1-dev.zip

Disable different combinations of required and optional plugins, and verify that the DDEV plugin notifies about the missing ones correctly.

Examples:

  • Enabling DDEV when Docker is disabled:
    image
  • Node.js Remote Interpreter is disabled:
    image
  • PHP Docker & PHP Remote Interpreter are disabled:
    image

Warnings about missing dependencies are now also displayed in the DDEV settings panel:
image

Related Issue Link(s):

@github-project-automation github-project-automation bot moved this to In progress in Development Apr 28, 2025
@AkibaAT AkibaAT added bug Something isn't working confirmed The issue is confirmed to be caused by the plugin labels Apr 29, 2025
@AkibaAT AkibaAT self-assigned this Apr 29, 2025
@AkibaAT AkibaAT force-pushed the bug/402-init-exception branch 2 times, most recently from 1c91c62 to 41fce53 Compare April 30, 2025 22:47
@AkibaAT AkibaAT force-pushed the bug/402-init-exception branch from 41fce53 to 7583499 Compare April 30, 2025 22:49
@AkibaAT AkibaAT requested a review from wazum April 30, 2025 23:08
@AkibaAT AkibaAT changed the title fix: update plugin dependency checks, fixes #402 fix: update plugin dependency checks and notifications, fixes #402 Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue is confirmed to be caused by the plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant