Skip to content

Conversation

@jjunier
Copy link
Member

@jjunier jjunier commented Jul 10, 2025

๐Ÿ“Œ PR ๊ฐœ์š”

ํ•ด๋‹น PR์ด ํฌํ•จํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ ๋˜๋Š” ๋ชฉ์ ์„ ๊ฐ„๋žตํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

.gitigore์„ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค. ๋‹ค์Œ ํŒŒ์ผ์„ ๊ตฌ์„ฑํ•˜๋Š” ๋‚ด์šฉ์€ github์—์„œ ์ œ๊ณตํ•˜๋Š” python์šฉ .gitignore์—์„œ ๊ฐ€์ ธ์™”์Šต๋‹ˆ๋‹ค.
Github Official Python.gitignore

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

์ฝ”๋“œ ํ’ˆ์งˆ๊ณผ ํ˜‘์—… ํšจ์œจ์„ ์œ„ํ•ด ๋ณ‘ํ•ฉ ์ „์— ๋‹ค์Œ์˜ ์งˆ๋ฌธ์„ ๊ธฐ๋ฐ˜์œผ๋กœ ์ ๊ฒ€ํ•ด์ฃผ์„ธ์š”.

  • ์ฝ”๋“œ๊ฐ€ ์ž˜ ์‹คํ–‰๋ผ์š” (์—๋Ÿฌ ์—†์–ด์š”)
  • ๋‚ด ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ๋‹ค๋ฅธ ํŒŒํŠธ์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š์•„์š” (๊ฐ€๋Šฅํ•˜๋ฉด!)
  • ํŒ€์—์„œ ์ •ํ•œ ์ฝ”๋“œ ์Šคํƒ€์ผ๊ณผ ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์„ ์ž˜ ๋”ฐ๋ž์–ด์š”
  • ๊ด€๋ จ ์ด์Šˆ๋‚˜ ์„ค๋ช…์ด ํ•„์š”ํ•œ ๋‚ด์šฉ์€ ์•„๋ž˜์— ์ ์—ˆ์–ด์š”

โœ๏ธ ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

ํ•ต์‹ฌ ๋ณ€๊ฒฝ๋“ค์„ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • Python์šฉ .gitignore ์ถ”๊ฐ€

๐Ÿงช ๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท or ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ (์„ ํƒ)

์ดํ•ด์— ๋„์›€๋  ์Šคํฌ๋ฆฐ์ƒท์„ ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”.

๐Ÿ“Ž ๊ด€๋ จ ์ด์Šˆ

๊ด€๋ จ๋œ ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”. (์˜ˆ: #12, JIRA-23 ๋“ฑ)

๐Ÿ’ฌ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํ•˜๊ณ  ์‹ถ์€ ๋ง (์„ ํƒ)

์„ค๋ช…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„, ๊ณ ๋ฏผํ–ˆ๋˜ ์ , ๋ฆฌ๋ทฐ ์š”์ฒญ ํฌ์ธํŠธ ๋“ฑ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

@jjunier jjunier requested a review from sulsikan July 10, 2025 02:21
@jjunier jjunier added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 10, 2025
@sulsikan
Copy link
Contributor

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!

Copy link
Contributor

@sulsikan sulsikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ ‡๊ฒŒ ์Šน์ธํ•˜๋Š”๊ฑฐ๊ตฐ์š”... ๋ฐฐ์šฐ๊ณ  ๊ฐ‘๋‹ˆ๋‹ค!

@sulsikan
Copy link
Contributor

.

Copy link
Contributor

@sulsikan sulsikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@jjunier jjunier merged commit 507b716 into main Jul 10, 2025
2 checks passed
@jjunier jjunier self-assigned this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants