Skip to content

Conversation

@jjunier
Copy link
Member

@jjunier jjunier commented Jul 15, 2025

๐Ÿ“Œ PR ๊ฐœ์š”

ํ•ด๋‹น PR์ด ํฌํ•จํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ ๋˜๋Š” ๋ชฉ์ ์„ ๊ฐ„๋žตํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

pre-commit ์ž๋™ํ™” ํ™˜๊ฒฝ ๊ตฌ์ถ• ๋ฐ requirements.txt ์—…๋ฐ์ดํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

์ฝ”๋“œ ํ’ˆ์งˆ๊ณผ ํ˜‘์—… ํšจ์œจ์„ ์œ„ํ•ด ๋ณ‘ํ•ฉ ์ „์— ๋‹ค์Œ์˜ ์งˆ๋ฌธ์„ ๊ธฐ๋ฐ˜์œผ๋กœ ์ ๊ฒ€ํ•ด์ฃผ์„ธ์š”.

  • ์ฝ”๋“œ๊ฐ€ ์ž˜ ์‹คํ–‰๋ผ์š” (์—๋Ÿฌ ์—†์–ด์š”)
  • ๋‚ด ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ๋‹ค๋ฅธ ํŒŒํŠธ์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š์•„์š” (๊ฐ€๋Šฅํ•˜๋ฉด!)
  • ํŒ€์—์„œ ์ •ํ•œ ์ฝ”๋“œ ์Šคํƒ€์ผ๊ณผ ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์„ ์ž˜ ๋”ฐ๋ž์–ด์š”
  • ๊ด€๋ จ ์ด์Šˆ๋‚˜ ์„ค๋ช…์ด ํ•„์š”ํ•œ ๋‚ด์šฉ์€ ์•„๋ž˜์— ์ ์—ˆ์–ด์š”

โœ๏ธ ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

ํ•ต์‹ฌ ๋ณ€๊ฒฝ๋“ค์„ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • .pre-commit-config.yaml ํŒŒ์ผ ์ƒ์„ฑ: ruff ๋ฆฐํŠธ, ํฌ๋งทํ„ฐ, ๋ณด์•ˆ ๊ฒ€์‚ฌ ๋“ฑ hook ์„ค์ • ์ถ”๊ฐ€
  • requirements.txt ์—…๋ฐ์ดํŠธ: ruff ๋ฒ„์ „ ์ถ”๊ฐ€ ๋ฐ pre-commit ์‹คํ–‰์„ ์œ„ํ•œ ์˜์กด์„ฑ ์ถ”๊ฐ€
  • ํŒ…์›๋“ค์ด pre-commit install๋งŒ์œผ๋กœ ๋™์ผํ•œ ๋กœ์ปฌ ์ž๋™ ๊ฒ€์‚ฌ ํ™˜๊ฒฝ์„ ๊ฐ–์ถœ ์ˆ˜ ์žˆ๋„๋ก ์ค€๋น„

๐Ÿงช ๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท or ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ (์„ ํƒ)

์ดํ•ด์— ๋„์›€๋  ์Šคํฌ๋ฆฐ์ƒท์„ ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”.

๐Ÿ“Ž ๊ด€๋ จ ์ด์Šˆ

๊ด€๋ จ๋œ ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”. (์˜ˆ: #12, JIRA-23 ๋“ฑ)

๐Ÿ’ฌ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํ•˜๊ณ  ์‹ถ์€ ๋ง (์„ ํƒ)

์„ค๋ช…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„, ๊ณ ๋ฏผํ–ˆ๋˜ ์ , ๋ฆฌ๋ทฐ ์š”์ฒญ ํฌ์ธํŠธ ๋“ฑ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

@jjunier
Copy link
Member Author

jjunier commented Jul 15, 2025

requirements.txt conflict issue -> CI/CD + Crawling + AWS Integration Libraries ์ •๋ฆฌ

@jjunier jjunier merged commit f615c43 into main Jul 15, 2025
1 check passed
@jjunier jjunier self-assigned this Jul 15, 2025
@jjunier jjunier added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants