Skip to content

Conversation

@sulsikan
Copy link
Contributor

πŸ“Œ PR κ°œμš”

ν•΄λ‹Ή PR이 ν¬ν•¨ν•˜λŠ” μ£Όμš” λ³€κ²½ 사항 λ˜λŠ” λͺ©μ μ„ κ°„λž΅νžˆ μ„€λͺ…ν•΄μ£Όμ„Έμš”.

  • 일뢀 μ œν’ˆ reviewdetail νŒŒμ‹± λˆ„λ½ λΆ€λΆ„ μˆ˜μ •

βœ… PR 체크리슀트

μ½”λ“œ ν’ˆμ§ˆκ³Ό ν˜‘μ—… νš¨μœ¨μ„ μœ„ν•΄ 병합 전에 λ‹€μŒμ˜ μ§ˆλ¬Έμ„ 기반으둜 μ κ²€ν•΄μ£Όμ„Έμš”.

  • μ½”λ“œκ°€ 잘 μ‹€ν–‰λΌμš” (μ—λŸ¬ μ—†μ–΄μš”)
  • λ‚΄ 변경사항이 λ‹€λ₯Έ νŒŒνŠΈμ— 영ν–₯을 μ£Όμ§€ μ•Šμ•„μš” (κ°€λŠ₯ν•˜λ©΄!)
  • νŒ€μ—μ„œ μ •ν•œ μ½”λ“œ μŠ€νƒ€μΌκ³Ό 컀밋 μ»¨λ²€μ…˜μ„ 잘 λ”°λžμ–΄μš”
  • κ΄€λ ¨ μ΄μŠˆλ‚˜ μ„€λͺ…이 ν•„μš”ν•œ λ‚΄μš©μ€ μ•„λž˜μ— μ μ—ˆμ–΄μš”

✏️ μ£Όμš” λ³€κ²½ 사항

핡심 변경듀을 자유둭게 μ μ–΄μ£Όμ„Έμš”.

  • 일뢀 μ œν’ˆ reviewdetail νŒŒμ‹± λˆ„λ½ λΆ€λΆ„ μˆ˜μ •
    • 리뷰 μš”μ•½ μ œν’ˆμ΄ μžˆλŠ” μƒν’ˆμž„μ—λ„ λΆˆκ΅¬ν•˜κ³  Airflow DAG 데이터 μˆ˜μ§‘ μ‹€ν–‰ λ‘œκ·Έμ—μ„œ μˆ˜μ§‘ λˆ„λ½λœ μ œν’ˆμ„ 발견
    • HTML μ½”λ“œλ₯Ό ν™•μΈν•œ κ²°κ³Ό dl νƒœκ·Έμ˜ class λ„€μž„μ΄ λ‹€λ₯΄λ‹€λŠ” 것을 발견
    • λ‹€λ₯Έ μ œν’ˆλ“€μ€ poll_type2 type3 클래슀λ₯Ό μ‚¬μš©ν•˜κ³  μžˆμ–΄ for dl in poll_div.select("dl.poll_type2.type3"): μ½”λ“œλ‘œ 리뷰λ₯Ό μˆ˜μ§‘ν–ˆμ§€λ§Œ, 샴푸 μ œν’ˆλ“€μ€ λŒ€λΆ€λΆ„ poll_type2만 μ‚¬μš©ν•˜κ³  μžˆμ–΄ ν•΄λ‹Ή μ½”λ“œλ‘œ μˆ˜μ§‘μ΄ λ˜μ§€ μ•ŠμŒ. ν•΄λ‹Ή λΆ€λΆ„ μ½”λ“œ μˆ˜μ •.

πŸ§ͺ πŸ“· μŠ€ν¬λ¦°μƒ· or ν…ŒμŠ€νŠΈ κ²°κ³Ό (선택)

이해에 도움될 μŠ€ν¬λ¦°μƒ·μ„ μ²¨λΆ€ν•΄μ£Όμ„Έμš”.

image

πŸ“Ž κ΄€λ ¨ 이슈

κ΄€λ ¨λœ 이슈 번호λ₯Ό μ μ–΄μ£Όμ„Έμš”. (예: #12, JIRA-23 λ“±)

πŸ’¬ λ¦¬λ·°μ–΄μ—κ²Œ ν•˜κ³  싢은 말 (선택)

μ„€λͺ…이 ν•„μš”ν•œ λΆ€λΆ„, κ³ λ―Όν–ˆλ˜ 점, 리뷰 μš”μ²­ 포인트 λ“± 자유둭게 μ μ–΄μ£Όμ„Έμš”.

@sulsikan sulsikan requested a review from jjunier as a code owner July 26, 2025 14:05
@jjunier jjunier added the enhancement New feature or request label Aug 3, 2025
Copy link
Member

@jjunier jjunier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μŠ€ν¬λ¦°μƒ· 2025-07-23 235345

λ‹€μŒκ³Ό 같이 일뢀 μ œν’ˆμ˜ 리뷰 상세 사항데이터 μˆ˜μ§‘μ—μ„œ λ°œμƒν•œ νŒŒμ‹± λˆ„λ½ μ΄μŠˆμ— λŒ€ν•œ μ μ ˆν•œ λŒ€μ²˜μΈ 것 κ°™μŠ΅λ‹ˆλ‹€. μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€.

@jjunier jjunier merged commit 48fc8a1 into main Aug 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants