Skip to content

Conversation

@kimwestg
Copy link
Contributor

๐Ÿ“Œ PR ๊ฐœ์š”

ํ•ด๋‹น PR์ด ํฌํ•จํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ ๋˜๋Š” ๋ชฉ์ ์„ ๊ฐ„๋žตํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

  • ํ‘ธ๋“œ ๋ฐ ํ—ฌ์Šค์ผ€์–ด ์นดํ…Œ๊ณ ๋ฆฌ ํฌ๋กค๋ง ํ•จ์ˆ˜

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

์ฝ”๋“œ ํ’ˆ์งˆ๊ณผ ํ˜‘์—… ํšจ์œจ์„ ์œ„ํ•ด ๋ณ‘ํ•ฉ ์ „์— ๋‹ค์Œ์˜ ์งˆ๋ฌธ์„ ๊ธฐ๋ฐ˜์œผ๋กœ ์ ๊ฒ€ํ•ด์ฃผ์„ธ์š”.

  • ์ฝ”๋“œ๊ฐ€ ์ž˜ ์‹คํ–‰๋ผ์š” (์—๋Ÿฌ ์—†์–ด์š”)
  • ๋‚ด ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ๋‹ค๋ฅธ ํŒŒํŠธ์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š์•„์š” (๊ฐ€๋Šฅํ•˜๋ฉด!)
  • ํŒ€์—์„œ ์ •ํ•œ ์ฝ”๋“œ ์Šคํƒ€์ผ๊ณผ ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์„ ์ž˜ ๋”ฐ๋ž์–ด์š”
  • ๊ด€๋ จ ์ด์Šˆ๋‚˜ ์„ค๋ช…์ด ํ•„์š”ํ•œ ๋‚ด์šฉ์€ ์•„๋ž˜์— ์ ์—ˆ์–ด์š”

โœ๏ธ ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

ํ•ต์‹ฌ ๋ณ€๊ฒฝ๋“ค์„ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

๐Ÿงช ๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท or ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ (์„ ํƒ)

์ดํ•ด์— ๋„์›€๋  ์Šคํฌ๋ฆฐ์ƒท์„ ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”.

๐Ÿ“Ž ๊ด€๋ จ ์ด์Šˆ

๊ด€๋ จ๋œ ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”. (์˜ˆ: #12, JIRA-23 ๋“ฑ)

๐Ÿ’ฌ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํ•˜๊ณ  ์‹ถ์€ ๋ง (์„ ํƒ)

์„ค๋ช…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„, ๊ณ ๋ฏผํ–ˆ๋˜ ์ , ๋ฆฌ๋ทฐ ์š”์ฒญ ํฌ์ธํŠธ ๋“ฑ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

@kimwestg kimwestg requested a review from jjunier as a code owner July 27, 2025 06:20
@kimwestg kimwestg closed this Jul 27, 2025
@kimwestg kimwestg reopened this Jul 27, 2025
Copy link
Member

@jjunier jjunier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์นดํ…Œ๊ณ ๋ฆฌ๋ณ„ ์ฝ”๋“œ ์žฌ์‚ฌ์šฉ์„ฑ ์ธก๋ฉด์—์„œ๋Š” ์ฃผ์–ธ๋‹˜์˜ ๊ตฌํ˜„์ด ์กฐ๊ธˆ ๋” ์ ํ•ฉํ•˜๋‹ค๊ณ  ํŒ๋‹จ๋˜์–ด ํ•ด๋‹น ์ฝ”๋“œ๋ฅผ ๊ธฐ๋ฐ˜์œผ๋กœ ๊ฐœ๋ฐœ์„ ์ง„ํ–‰ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค๋งŒ ์„œ๊ฒฝ๋‹˜์˜ ์ฝ”๋“œ๋„ ๊ตฌ์กฐ๋‚˜ ํ’ˆ์งˆ ๋ฉด์—์„œ ๋งค์šฐ ํ›Œ๋ฅญํ•˜์—ฌ ์ „ํ˜€ ์†์ƒ‰์ด ์—†์Šต๋‹ˆ๋‹ค. ์ˆ˜๊ณ  ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค.

@jjunier jjunier merged commit 0de4ad8 into main Aug 3, 2025
2 checks passed
@jjunier jjunier added enhancement New feature or request good first issue Good for newcomers labels Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants