-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/crawl skincare #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
โฆnto feature/crawl-skincare
โฆ -> selenium ์ผ๋ก ์์
โฆnto feature/crawl-skincare
โฆuys/olvy-insight into feature/crawl-skincare
โฆnto feature/crawl-skincare
โฆuys/olvy-insight into feature/crawl-skincare
|
PR Check ๋จ๊ณ์์ Ruff ๊ธฐ๋ฐ Code Lint ํ์์ ๋ง์ง ์๋ ์ฝ๋๊ฐ ๋ฐ๊ฒฌ๋์๋ ๋ณด๋ค์. ๊ทธ๋ฆฌ๊ณ docs/Ruff-guide.md ๋ฌธ์๋ ์ด์ ์ ์์ ์ฌํญ์ด ์์๋๋ฐ ํฌ๋กค๋ง feature branch์ ๋ฐ์์ด ์ ๋ ๊ฒ๋ ํ์ธ์ด ๋ฉ๋๋ค. |
โฆnto feature/crawl-skincare
|
ruff๋ก ์ฝ๋ ํ์ ์ฒดํฌ์งํ๊ณผ docs/Ruff-guide.md ๋ฌธ์ ์์ ์ฌํญ ๋ณ๊ฒฝ ์ ์ฉํ์ต๋๋ค! |
jjunier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.gitignore ํ์ผ ์ธํ ์ด ์ ๋์ด ์์๊ตฐ์.. ์ ๊ฐ ์ด๋ฐ ์ค์๋ฅผ ํ๋ค๋..
์ผ๋ฅธ ์์ ํ์ main์ผ๋ก ๋ณํฉ ํด๋ํ ๋ ์ ์ PR ๋ณด๋ฅ ๋ฐ๋๊ฒ์..
์ฃ์กํฉ๋๋ค ๐๐
|
.gitignore ํ์ผ๋ ์ ์ฉ๋์ต๋๋ค~! |
jjunier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํฌ๋กค๋ง ํํธ ์๊ณ ํ์ จ์ต๋๋ค~!
๐ PR ๊ฐ์
โ PR ์ฒดํฌ๋ฆฌ์คํธ
โ๏ธ ์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ
๐งช ๐ท ์คํฌ๋ฆฐ์ท or ํ ์คํธ ๊ฒฐ๊ณผ (์ ํ)
๐ ๊ด๋ จ ์ด์
close #7
close #8
๐ฌ ๋ฆฌ๋ทฐ์ด์๊ฒ ํ๊ณ ์ถ์ ๋ง (์ ํ)