Skip to content

Conversation

@sulsikan
Copy link
Contributor

@sulsikan sulsikan commented Jul 9, 2025

๐Ÿ“Œ PR ๊ฐœ์š”

ํ•ด๋‹น PR์ด ํฌํ•จํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ ๋˜๋Š” ๋ชฉ์ ์„ ๊ฐ„๋žตํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.

  • ์Šคํ‚จ์ผ€์–ด ๋žญํ‚น, ๋ธŒ๋žœ๋“œ ๋ฐ์ดํ„ฐ ์ˆ˜์ง‘ ํŒŒ์ผ ์ถ”๊ฐ€
  • ๋กœ์ปฌ docker ํ™˜๊ฒฝ airflow DAG ํ…Œ์ŠคํŠธ ํ†ต๊ณผ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

์ฝ”๋“œ ํ’ˆ์งˆ๊ณผ ํ˜‘์—… ํšจ์œจ์„ ์œ„ํ•ด ๋ณ‘ํ•ฉ ์ „์— ๋‹ค์Œ์˜ ์งˆ๋ฌธ์„ ๊ธฐ๋ฐ˜์œผ๋กœ ์ ๊ฒ€ํ•ด์ฃผ์„ธ์š”.

  • ์ฝ”๋“œ๊ฐ€ ์ž˜ ์‹คํ–‰๋ผ์š” (์—๋Ÿฌ ์—†์–ด์š”)
  • ๋‚ด ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ๋‹ค๋ฅธ ํŒŒํŠธ์— ์˜ํ–ฅ์„ ์ฃผ์ง€ ์•Š์•„์š” (๊ฐ€๋Šฅํ•˜๋ฉด!)
  • ํŒ€์—์„œ ์ •ํ•œ ์ฝ”๋“œ ์Šคํƒ€์ผ๊ณผ ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์„ ์ž˜ ๋”ฐ๋ž์–ด์š”
  • ๊ด€๋ จ ์ด์Šˆ๋‚˜ ์„ค๋ช…์ด ํ•„์š”ํ•œ ๋‚ด์šฉ์€ ์•„๋ž˜์— ์ ์—ˆ์–ด์š”

โœ๏ธ ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

ํ•ต์‹ฌ ๋ณ€๊ฒฝ๋“ค์„ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • ERD์— ์ž‘์„ฑํ•œ ์ปฌ๋Ÿผ์˜ ๋ฐ์ดํ„ฐ๋ฅผ ๋ชจ๋‘ ์ˆ˜์ง‘ํ•˜๋„๋ก ์ˆ˜์ •
  • docker ํ™˜๊ฒฝ์—์„œ๋„ ์‹คํ–‰ ๊ฐ€๋Šฅํ•˜๋„๋ก selenium ๋“œ๋ผ์ด๋ฒ„ ๋ถ€๋ถ„์„ ์ˆ˜์ •
  • from airflow.utils.log.logging_mixin import LoggingMixin์„ ํ†ตํ•ด Airflow์˜ ๋‚ด์žฅ ๋กœ๊น… ์‹œ์Šคํ…œ์„ ์‚ฌ์šฉํ•˜์˜€์œผ๋ฉฐ, ์ด๋ฅผ ํ†ตํ•ด ๋กœ๊ทธ๊ฐ€ Airflow ์›น UI ๋ฐ ๋กœ๊ทธ ํŒŒ์ผ์— ์ž๋™ ์ถœ๋ ฅ๋˜๋„๋ก ์„ค์ •
  • ruff ์ ์šฉ
  • docs/ruff-guide.md ๋ณ€๊ฒฝ์‚ฌํ•ญ ์ ์šฉ

๐Ÿงช ๐Ÿ“ท ์Šคํฌ๋ฆฐ์ƒท or ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ (์„ ํƒ)

์ดํ•ด์— ๋„์›€๋  ์Šคํฌ๋ฆฐ์ƒท์„ ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”.

๐Ÿ“Ž ๊ด€๋ จ ์ด์Šˆ

๊ด€๋ จ๋œ ์ด์Šˆ ๋ฒˆํ˜ธ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”. (์˜ˆ: #12, JIRA-23 ๋“ฑ)

close #7
close #8

๐Ÿ’ฌ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํ•˜๊ณ  ์‹ถ์€ ๋ง (์„ ํƒ)

์„ค๋ช…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„, ๊ณ ๋ฏผํ–ˆ๋˜ ์ , ๋ฆฌ๋ทฐ ์š”์ฒญ ํฌ์ธํŠธ ๋“ฑ ์ž์œ ๋กญ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

sulsikan and others added 24 commits July 1, 2025 11:11
โ€ฆ -> selenium ์œผ๋กœ ์ˆ˜์ •
@sulsikan sulsikan requested a review from jjunier as a code owner July 9, 2025 12:04
@sulsikan sulsikan closed this Jul 9, 2025
@jjunier
Copy link
Member

jjunier commented Jul 9, 2025

PR Check ๋‹จ๊ณ„์—์„œ Ruff ๊ธฐ๋ฐ˜ Code Lint ํ˜•์‹์•  ๋งž์ง€ ์•Š๋Š” ์ฝ”๋“œ๊ฐ€ ๋ฐœ๊ฒฌ๋˜์—ˆ๋‚˜ ๋ณด๋„ค์š”.

๊ทธ๋ฆฌ๊ณ  docs/Ruff-guide.md ๋ฌธ์„œ๋„ ์ด์ „์— ์ˆ˜์ • ์‚ฌํ•ญ์ด ์žˆ์—ˆ๋Š”๋ฐ ํฌ๋กค๋ง feature branch์— ๋ฐ˜์˜์ด ์•ˆ ๋œ ๊ฒƒ๋„ ํ™•์ธ์ด ๋ฉ๋‹ˆ๋‹ค.
โ†’ ์ด ๋ถ€๋ถ„์€ ์ œ๊ฐ€ ์ ์šฉํ•ด์„œ ์—…๋ฐ์ดํŠธ ํ•ด๋†“๊ฒ ์Šต๋‹ˆ๋‹ค.

@jjunier jjunier added good first issue Good for newcomers enhancement New feature or request labels Jul 9, 2025
@sulsikan
Copy link
Contributor Author

ruff๋กœ ์ฝ”๋“œ ํ˜•์‹ ์ฒดํฌ์ง„ํ–‰๊ณผ docs/Ruff-guide.md ๋ฌธ์„œ ์ˆ˜์ •์‚ฌํ•ญ ๋ณ€๊ฒฝ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค!

@sulsikan sulsikan reopened this Jul 10, 2025
@sulsikan sulsikan closed this Jul 10, 2025
@sulsikan sulsikan reopened this Jul 10, 2025
Copy link
Member

@jjunier jjunier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore ํŒŒ์ผ ์„ธํŒ…์ด ์•ˆ ๋˜์–ด ์žˆ์—ˆ๊ตฐ์š”.. ์ œ๊ฐ€ ์ด๋Ÿฐ ์‹ค์ˆ˜๋ฅผ ํ•˜๋‹ค๋‹ˆ..

์–ผ๋ฅธ ์ž‘์—… ํ›„์— main์œผ๋กœ ๋ณ‘ํ•ฉ ํ•ด๋‘˜ํ…Œ๋‹ˆ ์ž ์‹œ PR ๋ณด๋ฅ˜ ๋ฐ”๋ž„๊ฒŒ์š”..

์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค ๐Ÿ™๐Ÿ™

@sulsikan
Copy link
Contributor Author

.gitignore ํŒŒ์ผ๋„ ์ ์šฉ๋์Šต๋‹ˆ๋‹ค~!

Copy link
Member

@jjunier jjunier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํฌ๋กค๋ง ํŒŒํŠธ ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค~!

@jjunier jjunier merged commit 6a9e905 into main Jul 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

3 participants