-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ReadMe with info about usage in new environments #887
base: master
Are you sure you want to change the base?
Conversation
there is quite many more chains of require calls in the readme |
do you have merge access? |
no |
You're right, I'll remove it. Thanks for the reminder :) The issue template about trash comments is also no longer relevant now that Github removed its "how to Github" courses that referred to this repository for some reason, encouraging people to post nonsense comments and issues. As for the changes, it's all good, but you're missing the |
Sorted. Sorry, I made the original PR in a rush to check for a pulse when destructuring Debug was causing unexpected results. I was intentionally making it as small and easy to merge as possible, just to see if anyone was here. I came back here after I saw this https://feathersjs.com/guides/migrating.html#debugging Anyways I added a note or two about ESM. I tested it using I could have used the far more minimal vite.new/vanilla-ts but old habits die hard. |
From #786 (comment)
Requested by @jimmywarting and @Qix-
This removes difficult to use ES5 conventions and prepares us for v5. As someone who started using Node after ES6 with ESM as much as possible, the code and the readme was hard to read.
ps your issue template is 5 years old and not particularly relevant today.