Repository navigation
fix(launch): name armed logpoints instead of saying "no breakpoints" (#865) - #872
Merged
Merged
Conversation
…865) A launch whose only armed instrument was a logpoint answered "nothing is armed to stop it (no breakpoints, no entry stop, no caught-exception filter)". Both halves are true — a logpoint never stops the program — but "no breakpoints" reads as "your logpoint was not registered", the first thing a caller checks when a logpoint seems silent (#850 was found by exactly that doubt). describeLaunchArming already saw those logpoints and dropped them; it now counts them (`logpoints`) and words them (`loggingSummary`) apart from the armed summary, whose meaning is unchanged. launchStillRunning and waitForStopPending take the clause and say "1 logpoint(s) that log without stopping is armed (read get_output for the messages), and nothing is armed to stop it (no pausing breakpoints, …)"; with breakpoints as well, both are named. The unarmed wording without logpoints is untouched. Verified live through the dev server and by debugging a nested mcp-debugger with a breakpoint inside describeLaunchArming: the inner start_debugging (a logpoint on ticker.js) paused there with lineBreakpoints=0, logpoints=1, logpointsRunOn=true, and answered with the new wording once resumed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
start_debugginglaunch whose only armed instrument is a logpoint answered "nothing is armed to stop it (no breakpoints, no entry stop, no caught-exception filter)". Both halves are true — a logpoint never stops the program — but "no breakpoints" reads as "your logpoint was not registered", the first thing a caller checks when a logpoint seems silent (#850 was found by exactly that doubt). The same wording shapedwait_for_stop's pending answer (#865).How
describeLaunchArmingalready saw logpoints the adapter runs on and dropped them. It now counts them (logpoints) and words them (loggingSummary: "1 logpoint(s) that log without stopping") apart from the armed summary —armed/summarykeep their meaning, and logpoints downgraded to pausing breakpoints (nosupportsLogPoints) are still armed as before.ErrorMessages.launchStillRunning(armedSummary, debuggerOffWhy, loggingSummary?)andwaitForStopPending(…, { loggingSummary })splice the clause in: "The program is running; 1 logpoint(s) that log without stopping is armed (read get_output for the messages), and nothing is armed to stop it (no pausing breakpoints, no entry stop, no caught-exception filter): …". With breakpoints as well, both are named. The wording without logpoints is untouched (the established lowercase "nothing is armed to stop it" phrase is kept, so existing tests anddocs/tool-reference.mdquotes still match).debug-launcher.tsandexecution-controller.tspass the clause through; the tool reference documents the new sentence.Verified
start_debugging→ the new sentence;get_outputshows the logpoint firing.dist/index.js http --port 0under the JavaScript adapter with a breakpoint insidedescribeLaunchArming(dist/session/launch/launch-arming.js:20); an MCP client drove the nested server through the same recipe. At the breakpoint,get_local_variablesreadlineBreakpoints: 0,logpoints: 1,logpointsThatPause: 0,logpointsRunOn: true;evaluate_expressionshowed the stored logpointverified: trueand the stackdescribeLaunchArming ← DebugLauncher.launch ← InFlightGuard.run. Aftercontinue_execution, the innerstart_debugging(held 45 s by the pause) answered with the new wording, and the nested server kept running.launch-arming.test.ts(counts,loggingSummary, alongside breakpoints, downgraded logpoints stay armed),error-messages.test.ts(three wording cases),session-manager-launch-contract.test.ts(logpoint-only launch answerspending: truenaming the logpoint, no "(no breakpoints,").npm run typecheck:all,npm run lint,node scripts/check-docs.mjs, session/utils/server unit suites green.Side finding filed while doing this: #871 (JavaScript
attach_to_processsilently dropsprocessId).Fixes #865
🤖 Generated with Claude Code