Repository navigation
test: wait for a just-spawned child to appear in the process table before asserting the helper lists it (main Windows CI red after #940) - #943
Merged
Conversation
…fore asserting the helper lists it (main Windows CI red after #940) On windows-latest the first scan right after spawn() came back empty while the child was alive; a scan 300 ms later listed it. The test now polls for the listing (up to 15 s) instead of asserting the first answer. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
debugmcpdev
added a commit
that referenced
this pull request
Oct 17, 2026
…iltered assertion (Flake Hunt red on main after #943) (#944) The second case of the process-table unit test queried the table right after spawn(), the same race #943 fixed for the first case: the pid is alive, so it survives the 300 ms poll, and the image filter then drops it because Win32_Process has not listed it yet (Flake Hunt 39027849623, windows-latest, seed 516586464: expected [] to equal [5740]). Wait for the listing first, with the sibling case's timeout, and say on the helper that the image check presumes a process old enough to be listed. Co-authored-by: JF <john.franklin@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main went red on the Windows lane right after #940 (run 39001840388):
tests/unit/test-utils/process-table.test.ts > lists a live node child under its imageasserted on the first scan right afterspawn(), which on windows-latest came back empty while the child was alive — the second case's scan 300 ms later listed the same pid. The test now polls for the listing (up to 15 s). Test-only; #941 and #942 fail the same lane for the same reason and are re-updated once this lands.🤖 Generated with Claude Code