feat(ui_input): support multi-line text input from scenes#743
Open
feat(ui_input): support multi-line text input from scenes#743
Conversation
Adds the new optional `multi_line` flag from `PBUiInput` (decentraland/protocol#394) and threads it through to `TextEntry`. When true the text input behaves as a multi-line textarea: plain Enter inserts a newline; Shift+Enter or NumpadEnter submits. Also bumps `bevy_simple_text_input` (robtfm/bevy_simple_text_input branch 0.16) to pick up the matching binding flip and a cursor-clamp fix that prevented panics when the buffer shrank past the cursor's line. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multi_lineflag fromPBUiInput(feat(ui_input): add multi_line flag to PBUiInput protocol#394) through toTextEntry. When true the text input becomes a multi-line textarea.bevy_simple_text_input(robtfm/bevy_simple_text_input branch 0.16) to:clamp(0, lines.len())→min(lines.len() - 1)) that allowedcursor.line == lines.len()through, which cosmic-text rejects withshape_until_cursor invalid cursor.🤖 Generated with Claude Code