Add production ERC-3643 onboarding review gates - #87
Open
0xMuang wants to merge 2 commits into
Open
Conversation
…rvice open Constraint: Live ERC-3643/ONCHAINID wiring must remain read-only verified before operator activation, and local demo/untracked deployments stay untouched. Rejected: Direct service activation from unchecked config | would bypass Safe/operator review and fail-closed live wiring gates. Confidence: high Scope-risk: moderate Directive: Production operators must review generated calldata and Safe proposal, execute externally, then run live verification before enabling venue, maker, signer, and inventory. Tested: toolkit npm, CLI npm, staged diff/secret/scratch scan, independent review. Not-tested: scripts/check blocked by pre-existing forge fmt drift in script/DeployProductionCore.s.sol and script/DemoScenarios.s.sol; E2E skipped to preserve untracked deployments and because no live production RPC was provided.
Constraint: The source CLI intentionally compiles sibling Toolkit sources, whose package-local dependencies are absent in a fresh runner until Toolkit installation. Rejected: Relying on developer node_modules hoisting | clean CI does not resolve ethers from the sibling CLI package. Confidence: high Scope-risk: narrow Directive: Keep source-checkout dependency installation ordered before compiling cross-package source imports. Tested: scripts/check.sh shell syntax and git diff check; failure reproduced in PRs #87-#89 as TS2307 for Toolkit ethers resolution. Not-tested: GitHub CI rerun pending push.
0xMuang
added a commit
that referenced
this pull request
Aug 23, 2026
Constraint: PR #88 is stacked on #87 and must include the clean-runner Toolkit installation order. Confidence: high Scope-risk: narrow Directive: Preserve stacked branch ancestry when correcting shared CI prerequisites. Tested: Merge completed without conflicts; downstream CI pending. Not-tested: GitHub CI rerun pending push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked dependency
Depends on #84, #85, and #86. This PR is intentionally based on
feature/provider-neutral-ta-kyc, notmain.Scope
Verification
PASS:
npm test --prefix services/toolkitnpm test --prefix services/cligit diff --cached --check.omx,review.md,jobspace*,contracts.md,deployments/, ordesc.mdstaged; secret-like hits are fail-closed validation patterns and test fixtures.Known blocker / not tested
scripts/check.shremains blocked only by pre-existing forge fmt drift inscript/DeployProductionCore.s.solandscript/DemoScenarios.s.sol.deployments/artifacts and because no live production RPC was provided.Production boundaries
No merge into
mainis requested here.