feat: productize SDK package releases - #89
Open
0xMuang wants to merge 2 commits into
Open
Conversation
Constraint: Preserve existing Anvil, GIWA and generated-project compatibility without adding dependencies or publishing credentials. Rejected: Treating repository-relative Toolkit output as package validation | it does not prove a clean external consumer can install the artifact. Confidence: high Scope-risk: narrow Directive: Keep npm versions separate from persisted schema and capability versions; incompatible schemas require explicit adapters and migration tests. Tested: Toolkit, RFQ and CLI package tests; Node 20 clean-project SDK product smoke including packed Toolkit import, RFQ conformance, CLI doctor/deploy and packaged Foundry contract build; shell syntax; git diff check. Not-tested: Public npm registry publish, release credentials, or live production deployment; scripts/check stops at pre-existing Solidity formatting drift.
0xMuang
added a commit
that referenced
this pull request
Aug 23, 2026
Constraint: The source CLI intentionally compiles sibling Toolkit sources, whose package-local dependencies are absent in a fresh runner until Toolkit installation. Rejected: Relying on developer node_modules hoisting | clean CI does not resolve ethers from the sibling CLI package. Confidence: high Scope-risk: narrow Directive: Keep source-checkout dependency installation ordered before compiling cross-package source imports. Tested: scripts/check.sh shell syntax and git diff check; failure reproduced in PRs #87-#89 as TS2307 for Toolkit ethers resolution. Not-tested: GitHub CI rerun pending push.
Constraint: PR #89 is stacked on #88 and must inherit the clean-runner Toolkit installation prerequisite. Confidence: high Scope-risk: narrow Directive: Preserve stacked branch ancestry when shared CI prerequisites change. Tested: Merge completed without conflicts; downstream CI pending. Not-tested: GitHub CI rerun pending push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an independently packable Toolkit artifact, installs CLI/Toolkit/RFQ tarballs in clean temporary consumers, validates Toolkit exports and generated RFQ conformance, and documents SemVer plus migration/rollback policy. Verified: Toolkit, RFQ and CLI tests pass; Node 20 scripts/sdk-product-smoke.sh passes including doctor/deploy and packaged Foundry build; sh -n and git diff --check pass. scripts/check.sh was run and stops only at pre-existing formatting drift in script/DeployProductionCore.s.sol and script/DemoScenarios.s.sol. Public npm publish, release credentials and live production deployment were not exercised. Stacked on #88; does not target main.