Skip to content

Conversation

nevermarine
Copy link
Collaborator

@nevermarine nevermarine commented Sep 30, 2025

Description

Add RBAC linting via DMT lint.

  • move virtualization-pre-delete-hook SA and Job to d8-system

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: ci
type: chore
summary: add RBAC linting

@nevermarine nevermarine added this to the v1.2.0 milestone Sep 30, 2025
Copy link

sourcery-ai bot commented Sep 30, 2025

Reviewer's Guide

Implements RBAC linting by enumerating explicit permissions in Kubernetes RBAC templates and updating the DMT lint configuration to enforce granular rules.

Flow diagram for RBAC permission enumeration process

flowchart TD
  A["RBAC Template with Wildcards"] -->|Remove wildcards| B["Enumerate Resources and Verbs"]
  B --> C["Update RBAC Template"]
  C --> D["Apply Explicit Permissions"]
  D --> E["RBAC Linting by DMT Lint"]
Loading

File-Level Changes

Change Details Files
Enumerate RBAC permissions across operator templates
  • Replaced wildcard '*' entries with explicit resource names and allowed verbs
  • Removed redundant CDI wildcard blocks
templates/kubevirt/virt-operator/rbac-for-us.yaml
templates/cdi/cdi-operator/rbac-for-us.yaml
templates/virtualization-controller/rbac-for-us.yaml
Refine DMT lint configuration for RBAC linting
  • Removed wildcard exclusions for specific ClusterRoles
  • Adjusted placement-based exclude-rules
.dmtlint.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Signed-off-by: Maksim Fedotov <[email protected]>
@nevermarine nevermarine force-pushed the chore/ci/add-rbac-linting branch from 79c1a43 to ca6187c Compare October 1, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant