Skip to content

Conversation

universal-itengineer
Copy link
Member

Description

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section:
type:
summary:

Copy link

sourcery-ai bot commented Oct 2, 2025

Reviewer's Guide

This PR establishes a framework for automated performance test scenarios by extending cloud-init templates, enhancing the evicter migration tool and bootstrap scripts, and provisioning a Netchecker service with kustomize manifests and orchestrating runner scripts.

File-Level Changes

Change Details Files
Parameterize cloud-init credentials and introduce conditional curl-ping service in the performance test template
  • Replaced static ubuntu user/password with templated image name value
  • Added conditional block installing packages and creating curl-ping scripts
  • Provided both OpenRC and systemd service definitions based on image name
  • Updated runcmd entries to start the curl-ping service dynamically
tests/performance/templates/_cloud-config.tpl
Enhance migration logic and bootstrap tooling for flexible topology configuration
  • Ensured targetCount in ContinuousMigrator is at least one and cleaned up log formatting
  • Extended bootstrap.sh to accept virtualDisk and virtualImage type flags and updated Helm arguments
  • Activated structured logging in evicter main.go
  • Included netchecker in Taskfile.yaml and added curlUrl and coreFraction adjustments in values.yaml
tests/performance/tools/evicter/internal/migration.go
tests/performance/bootstrap.sh
tests/performance/tools/evicter/cmd/main.go
tests/performance/Taskfile.yaml
tests/performance/values.yaml
Provision Netchecker testing infrastructure and orchestrate scenario execution
  • Added kustomize base and overlay manifests for Netchecker (namespace, configmap, deployment, service, ingress, certificates, servicemonitor, Grafana dashboard)
  • Introduced run.sh script to deploy resources, wait for readiness, trigger migrations, and collect statistics
  • Provided deploy-prom-remote-writer.sh for Prometheus remote write configuration
tests/performance/tools/netchecker/base/gdd.yaml
tests/performance/tools/netchecker/base/*.yaml
tests/performance/tools/netchecker/overlays/test/kustomization.yaml
tests/performance/tools/netchecker/Taskfile.dist.yaml
tests/performance/scenarios/run.sh
tests/performance/scenarios/deploy-prom-remote-writer.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The cloud-config template now declares multiple write_files blocks under the same parent—consider consolidating or nesting them properly to avoid generating invalid YAML.
  • The deployment loops in scenarios/run.sh wait indefinitely on resource readiness; add a timeout or retry limit to fail fast when something doesn’t converge.
  • In bootstrap.sh the flags for VIRTUALDISK_TYPE and VIRTUALIMAGE_TYPE aren’t defaulted or validated—either provide sensible defaults or exit early on missing values.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The cloud-config template now declares multiple write_files blocks under the same parent—consider consolidating or nesting them properly to avoid generating invalid YAML.
- The deployment loops in scenarios/run.sh wait indefinitely on resource readiness; add a timeout or retry limit to fail fast when something doesn’t converge.
- In bootstrap.sh the flags for VIRTUALDISK_TYPE and VIRTUALIMAGE_TYPE aren’t defaulted or validated—either provide sensible defaults or exit early on missing values.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer universal-itengineer force-pushed the chore/test/automated-tests-scenarios branch 4 times, most recently from 60a660e to fc58286 Compare October 6, 2025 18:49
Signed-off-by: Nikita Korolev <[email protected]>
@universal-itengineer universal-itengineer force-pushed the chore/test/automated-tests-scenarios branch from fc58286 to 1ca5c4c Compare October 6, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant