-
Notifications
You must be signed in to change notification settings - Fork 2
Chore/test/automated tests scenarios #1527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Reviewer's GuideThis PR establishes a framework for automated performance test scenarios by extending cloud-init templates, enhancing the evicter migration tool and bootstrap scripts, and provisioning a Netchecker service with kustomize manifests and orchestrating runner scripts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The cloud-config template now declares multiple write_files blocks under the same parent—consider consolidating or nesting them properly to avoid generating invalid YAML.
- The deployment loops in scenarios/run.sh wait indefinitely on resource readiness; add a timeout or retry limit to fail fast when something doesn’t converge.
- In bootstrap.sh the flags for VIRTUALDISK_TYPE and VIRTUALIMAGE_TYPE aren’t defaulted or validated—either provide sensible defaults or exit early on missing values.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The cloud-config template now declares multiple write_files blocks under the same parent—consider consolidating or nesting them properly to avoid generating invalid YAML.
- The deployment loops in scenarios/run.sh wait indefinitely on resource readiness; add a timeout or retry limit to fail fast when something doesn’t converge.
- In bootstrap.sh the flags for VIRTUALDISK_TYPE and VIRTUALIMAGE_TYPE aren’t defaulted or validated—either provide sensible defaults or exit early on missing values.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
Signed-off-by: Nikita Korolev <[email protected]>
60a660e
to
fc58286
Compare
Signed-off-by: Nikita Korolev <[email protected]>
fc58286
to
1ca5c4c
Compare
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries