Skip to content

netsync: Detect and log db corruption on headers. #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davecgh merged 1 commit into from
Jan 24, 2026
Merged

netsync: Detect and log db corruption on headers. #3602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions internal/netsync/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,11 +1626,25 @@ func (m *SyncManager) OnHeaders(peer *Peer, headersMsg *wire.MsgHeaders) {
m.syncHeight.Store(newBestHeaderHeight)
}

// When the error is a rule error, it means the header was simply
// rejected as opposed to something actually going wrong, so log it
// as such. Otherwise, something really did go wrong, so log it as
// an actual error.
//
// Note that there is no need to check for an orphan header here
// because they were already verified to connect above.
var rErr blockchain.RuleError
if errors.As(err, &rErr) {
log.Debugf("Rejected block header %s from peer %s: %v -- "+
"disconnecting", header.BlockHash(), peer, err)
} else {
log.Errorf("Failed to process block header %s from peer %s: %v"+
" -- disconnecting", header.BlockHash(), peer, err)
}
if errors.Is(err, database.ErrCorruption) {
log.Errorf("Criticial failure: %v", err)
}

log.Debugf("Failed to process block header %s from peer %s: %v -- "+
"disconnecting", header.BlockHash(), peer, err)
peer.Disconnect()
return
}
Expand Down