mixing: Increment PRNG seed nonce for each test#3618
Merged
davecgh merged 1 commit intodecred:masterfrom Feb 18, 2026
Merged
Conversation
This avoids reusing the same initial seed for multiple tests when testing with -count greater than 1. The -seed flag now requires providing the initial nonce in the string, so that the failing test can be reproduced with -count=1. If a test fails, the flag to reproduce is logged at the end of the output.
davecgh
approved these changes
Feb 18, 2026
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
I made it optional in the code I'm working on which does similar based on our conversations about this, but no objections to it being required in these tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids reusing the same initial seed for multiple tests when testing with -count greater than 1.
The -seed flag now requires providing the initial nonce in the string, so that the failing test can be reproduced with -count=1. If a test fails, the flag to reproduce is logged at the end of the output.