wire: Add tests for short reads.#3623
Merged
davecgh merged 1 commit intodecred:masterfrom Feb 26, 2026
Merged
Conversation
davecgh
force-pushed
the
wire_short_read_tests
branch
from
42331cd to
99c6e78
Compare
Merged
This adds some additional tests for short reads. - Adds cases from some missing paths in the tests for readElement - Adds another scenario when testing readElement that reader that only provides at most one byte per Read - Adds a new test name TestShortReads that exercise each of the individual readX funcs with the various supported readers as well as a couple of readers for the default path including a one byte reader Together these tests help ensure all of the new short read paths are fully exercised.
davecgh
force-pushed
the
wire_short_read_tests
branch
from
99c6e78 to
90199bb
Compare
jrick
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some additional tests for short reads.
readElementreadElementthat reader that only provides at most one byte perReadTestShortReadsthat exercise each of the individualreadXfuncs with the various supported readers as well as a couple of readers for the default path including a one byte readerTogether these tests help ensure all of the new short read paths are fully exercised.