rpcserver: Ensure limited user is always limited.#3644
Merged
davecgh merged 2 commits intodecred:masterfrom Mar 10, 2026
Merged
rpcserver: Ensure limited user is always limited.#3644davecgh merged 2 commits intodecred:masterfrom
davecgh merged 2 commits intodecred:masterfrom
Conversation
- Comments and more descriptive names for tests. - Using t.Run() provides better test metrics and removes the need to include the name of the test in log lines. - Pull a block out TestCheckAuth and make it a separate test.
davecgh
reviewed
Mar 10, 2026
Member
davecgh
left a comment
davecgh
left a comment
There was a problem hiding this comment.
Nice find! Thanks for the PR.
davecgh
reviewed
Mar 10, 2026
This fixes an issue where the server treated an unset admin auth hash as unconditional success under the assumption that this state corresponds to the server running certificate auth. However, the server can also reach this state under basic auth by configuring limited credentials without admin credentials. In this case the limited user would have unrestricted access to all admin functions.
Member
Author
|
Included both of the suggested changes |
davecgh
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the server treated an unset admin auth hash as unconditional success under the assumption that this state corresponds to the server running certificate auth. However, the server can also reach this state under basic auth by configuring limited credentials without admin credentials. In this case the limited user would have unrestricted access to all admin functions.