Remove SpendLimit param from PurchaseTickets#2542
Merged
jrick merged 3 commits intodecred:masterfrom Sep 18, 2025
Merged
Conversation
jholdstock
force-pushed
the
spendlimit
branch
from
87b747a to
c8d300c
Compare
Member
|
I like the idea of removing this from the PurchaseTickets wallet api. The RPC changes should be performed with an update to their respective API versions. These are already bumped compared to release-v2.0, but it's been a long while since they were last touched and there may be clients that expect this version to mean what it currently does. This can be rolled up with any other breaking RPC changes if you have any planned for the immediate future. |
This param was tested to ensure it was non-negative but it was never used for anything more. Bumps json rpc to version 11.0.0.
This param was tested to ensure it was non-negative but it was never used for anything more. Bumps grpc to version 10.0.0.
jholdstock
force-pushed
the
spendlimit
branch
from
c8d300c to
7d12bcf
Compare
Member
Author
|
Bumped both RPC versions. |
jrick
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality of spend limit was removed from ticket purchasing in #1679. The param remains but it has no effect.
Comments from the time don't make it clear whether this was an deliberate change, but more recent comments seem to indicate that it was (also here).
We are currently in an unreleased major version bump so this seems like a good time to remove the param entirely.