Remove xpubAddress type and stakeAddress interface.#2561
Closed
jholdstock wants to merge 2 commits intodecred:masterfrom
Closed
Remove xpubAddress type and stakeAddress interface.#2561jholdstock wants to merge 2 commits intodecred:masterfrom
jholdstock wants to merge 2 commits intodecred:masterfrom
Conversation
All of the functionality provided by wrapping addresses in xpubAddress is either available in dcrd or it is unused. This also enables the removal of some unsafe unnecessary type conversion, and removes the need to pass around blank/dummy account names.
Member
Member
Author
|
Damn ok, I had no idea that was still active or maintained, I thought it was just an abadoned leftover from an old mobile wallet project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #2537.
This PR does away with
xPubAddresscompletely. I appreciate that the original goal was to return a more useful type to the caller, but given that the additional functionality is not actually used by any callers, I don't see the extra cruft it introduces to be worthwhile. Its quite a lot of duplicated/untested code to maintain "just in case" its useful in future.All of the functionality provided by wrapping addresses in
xpubAddressis either available in dcrd or it is unused.This also enables the removal of some unsafe unnecessary type conversion, and removes the need to pass around blank/dummy account names.