Skip to content

Explain why buyTickets is called multiple times. #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jholdstock wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explain why buyTickets is called multiple times. #2610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ticketbuyer/tb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2018-2025 The Decred developers
// Copyright (c) 2018-2026 The Decred developers
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.

Expand Down Expand Up @@ -164,6 +164,17 @@ func (tb *TB) Run(ctx context.Context, passphrase []byte) error {
cfg := tb.cfg
tb.mu.Unlock()

// If mixing is enabled and limit is greater than 1, buyTickets is
// called multiple times instead of once.
//
// i.e. buyTickets(1)*N instead of buyTickets(N).
//
// This enhances user privacy by preventing multiple tickets from
// sharing a common split tx and a common change output. The privacy
// improvement comes at the cost of potentially slowing the
// purchasing rate, e.g. breaking down a large single output to fund
// multiple tickets will take multiple blocks. This tradeoff is
// acceptable in the context of a long-running ticketbuyer.
multiple := 1
if cfg.Mixing {
multiple = cfg.Limit
Expand Down
Loading