Merged
Conversation
When wraparound of the uint64 peer ID counter occurs, take care to never conflict (sharing a peer ID) with existing peers who are still connected with the same ID. While here, continue to skip the zero ID (remote peer IDs always start at one) so zero can be reserved for local peer usage. Backport of 54a9b82.
There is currently no way to set the change account used by individual split transactions when running the ticket autobuyer without mixing, as this account was never looked up from the config. Allow the change account to be specified with unmixed ticket buying, defaulting to the purchase account if it is unset. The change account remains required if mixing is enabled. Backport of 0567ec5.
NewMsgTx preallocates input and output slices that Deserialize will immediately discard, causing unnecessary allocations. Backport of 1d35454.
The `authenticate` RPC command is registered using the wallet's own named type `AuthenticateCmd` derived from the dcrd type `AuthenticateCmd`. In Go, this creates a distinct type. `types.AuthenticateCmd` and `dcrdtypes.AuthenticateCmd` are not interchangeable in type assertions. Since `dcrjson.ParseParams` returns `*types.AuthenticateCmd` (the registered type), this assertion always fails. When it fails, `ok` is `false`, and the function returns `false` at line 326 — meaning "not invalid" — regardless of what credentials were supplied. There is a second bug in the same function: if `ParseParams` itself fails (e.g., malformed params), `invalidAuth` also returns `false` (line 322), which is fail-open rather than fail-closed. Backport of 54a3e95.
A variable shadowing bug prevented unknown PRs from being requested from peers. Backport of 33f6312.
Backport of ddc528c.
This updates to the following module releases: * secp256k1/v4 v4.4.1 * mixing v0.7.0 * wire v1.7.5 Backport of a52ba06.
davecgh
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.