Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements vad_events for SpeechStarted #162

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Implements vad_events for SpeechStarted #162

merged 1 commit into from
Jan 26, 2024

Conversation

davidvonthenen
Copy link
Contributor

Proposed changes

This implements vad_events in order to trigger speech started events.

The examples/streaming/microphone example has been updated to test the functionality.

Types of changes

What types of changes does your code introduce to the community Go SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NA

@davidvonthenen davidvonthenen marked this pull request as ready for review January 18, 2024 15:34
@davidvonthenen davidvonthenen marked this pull request as draft January 19, 2024 14:51
@davidvonthenen davidvonthenen marked this pull request as ready for review January 26, 2024 14:39
@davidvonthenen davidvonthenen merged commit 2a5c7a3 into deepgram:main Jan 26, 2024
1 check passed
@davidvonthenen davidvonthenen deleted the impl-vad-events-speech-start branch January 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants