Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Null Fields from Response Objects #174

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Remove Null Fields from Response Objects #174

merged 1 commit into from
Feb 1, 2024

Conversation

davidvonthenen
Copy link
Contributor

@davidvonthenen davidvonthenen commented Feb 1, 2024

Proposed changes

Addresses #163

For all parameters we don't want to include when null, use a pointer for JSON parsing. Tested using the examples.

NOTE: Combining just in the interest of time. Also fixes an issue with Paragraph -> Paragraphs: https://github.com/deepgram/deepgram-go-sdk/pull/174/files#diff-6d6a17cac219ff3f71886cf5d9bc5b4803f75690ab397ba1f72863920080d191R96

Types of changes

What types of changes does your code introduce to the community Go SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

@davidvonthenen davidvonthenen merged commit 710240d into deepgram:main Feb 1, 2024
1 check passed
@davidvonthenen davidvonthenen deleted the remove-null-field-from-response branch February 1, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants